-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: respect Coinbase wallet optons when preloading #3364
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 7304c5b The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Your org requires the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @joaquim-verges and the rest of your teammates on |
CodSpeed Performance ReportMerging #3364 will not alter performanceComparing Summary
|
size-limit report 📦
|
fixes #3350 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3364 +/- ##
==========================================
+ Coverage 62.82% 62.85% +0.03%
==========================================
Files 860 862 +2
Lines 63715 63910 +195
Branches 3449 3462 +13
==========================================
+ Hits 40026 40168 +142
- Misses 23014 23065 +51
- Partials 675 677 +2
*This pull request uses carry forward flags. Click here to find out more.
|
75be07b
to
7304c5b
Compare
Merge activity
|
PR-Codex overview
The focus of this PR is to respect the coinbase wallet create settings when preloading the provider.
Detailed summary
usePreloadWalletProviders
function to pass create wallet arguments when preloading the Coinbase provider.CreateWalletArgs
fromwallet-types.js
.