Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: respect Coinbase wallet optons when preloading #3364

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jun 17, 2024

PR-Codex overview

The focus of this PR is to respect the coinbase wallet create settings when preloading the provider.

Detailed summary

  • Updated the usePreloadWalletProviders function to pass create wallet arguments when preloading the Coinbase provider.
  • Added import for CreateWalletArgs from wallet-types.js.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jun 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 9:49pm

Copy link

changeset-bot bot commented Jun 17, 2024

🦋 Changeset detected

Latest commit: 7304c5b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
thirdweb Patch
@thirdweb-dev/sdk Patch
@thirdweb-dev/cli Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

graphite-app bot commented Jun 17, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@joaquim-verges joaquim-verges changed the title refactor: enhance Coinbase wallet preloading in usePreloadWalletProviders refactor: respect Coinbase wallet optons when preloading Jun 17, 2024
@joaquim-verges joaquim-verges marked this pull request as ready for review June 17, 2024 21:40
Copy link

codspeed-hq bot commented Jun 17, 2024

CodSpeed Performance Report

Merging #3364 will not alter performance

Comparing improve-wallet-provider-preloading (7304c5b) with main (2d7ebe2)

Summary

✅ 9 untouched benchmarks

Copy link
Contributor

github-actions bot commented Jun 17, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 40.59 KB (0%) 812 ms (0%) 3.9 s (+4.36% 🔺) 4.7 s
thirdweb (cjs) 90.32 KB (0%) 1.9 s (0%) 8.2 s (+13.99% 🔺) 10 s
thirdweb (minimal + tree-shaking) 4.75 KB (0%) 95 ms (0%) 161 ms (+29.78% 🔺) 256 ms
thirdweb/chains (tree-shaking) 423 B (0%) 10 ms (0%) 76 ms (+14.39% 🔺) 86 ms
thirdweb/react (minimal + tree-shaking) 13.47 KB (0%) 270 ms (0%) 492 ms (-28.72% 🔽) 762 ms

@joaquim-verges
Copy link
Member Author

fixes #3350

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.85%. Comparing base (321cf26) to head (75be07b).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3364      +/-   ##
==========================================
+ Coverage   62.82%   62.85%   +0.03%     
==========================================
  Files         860      862       +2     
  Lines       63715    63910     +195     
  Branches     3449     3462      +13     
==========================================
+ Hits        40026    40168     +142     
- Misses      23014    23065      +51     
- Partials      675      677       +2     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.60% <ø> (ø) Carriedforward from 321cf26
packages 62.28% <100.00%> (+0.03%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...b/src/react/web/utils/usePreloadWalletProviders.ts 76.92% <100.00%> (+1.41%) ⬆️

... and 6 files with indirect coverage changes

@joaquim-verges joaquim-verges force-pushed the improve-wallet-provider-preloading branch from 75be07b to 7304c5b Compare June 17, 2024 21:46
Copy link

graphite-app bot commented Jun 17, 2024

Merge activity

@graphite-app graphite-app bot merged commit 7304c5b into main Jun 17, 2024
22 of 23 checks passed
@graphite-app graphite-app bot deleted the improve-wallet-provider-preloading branch June 17, 2024 21:47
@jnsdls jnsdls mentioned this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants