fix: signing raw messages in ethers adapter

[joaquim-verges]

PR-Codex overview

This PR focuses on fixing the signing of raw messages through ethers 5/6 adapters.

Detailed summary

• Updated message signing logic in ethers 5 and 6 adapters to handle raw messages correctly
• Added tests for signing raw messages in ethers 5 and 6 adapters
• Added functionality to sign raw messages in viem adapter

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 17, 2024 11:43pm

[changeset-bot]

🦋 Changeset detected

Latest commit: 9dd1b5a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
thirdweb	Patch
@thirdweb-dev/sdk	Patch
@thirdweb-dev/cli	Patch
@thirdweb-dev/react-core	Patch
@thirdweb-dev/react	Patch
@thirdweb-dev/unity-js-bridge	Patch
@thirdweb-dev/wallets	Patch
@thirdweb-dev/auth	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[graphite-app]

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[joaquim-verges]

• fix: signing raw messages in ethers adapter #3366 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #3366 will not alter performance

_{Comparing add-sign-raw-message-test (9dd1b5a) with main (449ae19)}

Summary

✅ 9 untouched benchmarks

[joaquim-verges]

fixes #3301

[github-actions]

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	40.59 KB (0%)	812 ms (0%)	2 s (-23.68% 🔽)	2.8 s
thirdweb (cjs)	90.32 KB (0%)	1.9 s (0%)	4.2 s (+58.7% 🔺)	6 s
thirdweb (minimal + tree-shaking)	4.75 KB (0%)	95 ms (0%)	80 ms (-19.31% 🔽)	175 ms
thirdweb/chains (tree-shaking)	423 B (0%)	10 ms (0%)	61 ms (+8.02% 🔺)	71 ms
thirdweb/react (minimal + tree-shaking)	13.47 KB (0%)	270 ms (0%)	240 ms (-34.59% 🔽)	509 ms

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.90%. Comparing base (b9b622a) to head (ed6ff72).

❗ Current head ed6ff72 differs from pull request most recent head 9dd1b5a

Please upload reports for the commit 9dd1b5a to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3366      +/-   ##
==========================================
+ Coverage   62.85%   62.90%   +0.05%     
==========================================
  Files         862      861       -1     
  Lines       63910    63834      -76     
  Branches     3463     3462       -1     
==========================================
- Hits        40168    40154      -14     
+ Misses      23065    23003      -62     
  Partials      677      677              

Flag	Coverage Δ		*Carryforward flag
legacy_packages	65.60% <ø> (ø)		Carriedforward from b9b622a
packages	62.34% <100.00%> (+0.06%)	⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files	Coverage Δ
packages/thirdweb/src/adapters/ethers5.ts	56.05% <100.00%> (+0.09%)	⬆️
packages/thirdweb/src/adapters/ethers6.ts	57.47% <100.00%> (+0.10%)	⬆️

... and 1 file with indirect coverage changes

[graphite-app]

Merge activity

• Jun 17, 7:40 PM EDT: joaquim-verges added this pull request to the Graphite merge queue.
• Jun 17, 7:44 PM EDT: joaquim-verges merged this pull request with the Graphite merge queue.