CLI auto-updates on every run #441

adam-maj · 2022-12-02T22:26:48Z

No description provided.

changeset-bot · 2022-12-02T22:26:51Z

🦋 Changeset detected

Latest commit: c58ec99

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
thirdweb	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

adam-maj · 2022-12-02T22:31:40Z

/release-pr

github-actions · 2022-12-02T22:32:09Z

Size Change: +959 B (0%)

Total Size: 3.35 MB

Filename	Size	Change
`packages/cli/dist/cli/index.js`	157 kB	+959 B (+1%)

ℹ️ View Unchanged

Filename	Size
`packages/auth/express/dist/thirdweb-dev-auth-express.cjs.dev.js`	1.37 kB
`packages/auth/express/dist/thirdweb-dev-auth-express.cjs.js`	153 B
`packages/auth/express/dist/thirdweb-dev-auth-express.cjs.prod.js`	1.37 kB
`packages/auth/express/dist/thirdweb-dev-auth-express.esm.js`	1.24 kB
`packages/auth/next-auth/dist/thirdweb-dev-auth-next-auth.cjs.dev.js`	1.19 kB
`packages/auth/next-auth/dist/thirdweb-dev-auth-next-auth.cjs.js`	154 B
`packages/auth/next-auth/dist/thirdweb-dev-auth-next-auth.cjs.prod.js`	1.19 kB
`packages/auth/next-auth/dist/thirdweb-dev-auth-next-auth.esm.js`	1.05 kB
`packages/auth/next/dist/thirdweb-dev-auth-next.cjs.dev.js`	207 B
`packages/auth/next/dist/thirdweb-dev-auth-next.cjs.js`	152 B
`packages/auth/next/dist/thirdweb-dev-auth-next.cjs.prod.js`	209 B
`packages/auth/next/dist/thirdweb-dev-auth-next.esm.js`	113 B
`packages/auth/next/evm/dist/thirdweb-dev-auth-next-evm.cjs.dev.js`	1.39 kB
`packages/auth/next/evm/dist/thirdweb-dev-auth-next-evm.cjs.js`	155 B
`packages/auth/next/evm/dist/thirdweb-dev-auth-next-evm.cjs.prod.js`	1.39 kB
`packages/auth/next/evm/dist/thirdweb-dev-auth-next-evm.esm.js`	1.33 kB
`packages/auth/next/solana/dist/thirdweb-dev-auth-next-solana.cjs.dev.js`	1.4 kB
`packages/auth/next/solana/dist/thirdweb-dev-auth-next-solana.cjs.js`	156 B
`packages/auth/next/solana/dist/thirdweb-dev-auth-next-solana.cjs.prod.js`	1.4 kB
`packages/auth/next/solana/dist/thirdweb-dev-auth-next-solana.esm.js`	1.34 kB
`packages/cli/dist/helpers/hardhat-config-extractor.js`	383 B
`packages/contracts-js/dist/defineProperty-********.cjs.dev.js`	416 B
`packages/contracts-js/dist/defineProperty-********.cjs.prod.js`	416 B
`packages/contracts-js/dist/defineProperty-********.esm.js`	403 B
`packages/contracts-js/dist/thirdweb-dev-contracts-js.cjs.dev.js`	510 kB
`packages/contracts-js/dist/thirdweb-dev-contracts-js.cjs.js`	153 B
`packages/contracts-js/dist/thirdweb-dev-contracts-js.cjs.prod.js`	510 kB
`packages/contracts-js/dist/thirdweb-dev-contracts-js.esm.js`	508 kB
`packages/contracts-js/factories/TWFactory__factory/dist/thirdweb-dev-contracts-js-factories-TWFactory__factory.cjs.dev.js`	6.03 kB
`packages/contracts-js/factories/TWFactory__factory/dist/thirdweb-dev-contracts-js-factories-TWFactory__factory.cjs.js`	171 B
`packages/contracts-js/factories/TWFactory__factory/dist/thirdweb-dev-contracts-js-factories-TWFactory__factory.cjs.prod.js`	6.03 kB
`packages/contracts-js/factories/TWFactory__factory/dist/thirdweb-dev-contracts-js-factories-TWFactory__factory.esm.js`	5.97 kB
`packages/contracts-js/factories/TWFee__factory/dist/thirdweb-dev-contracts-js-factories-TWFee__factory.cjs.dev.js`	5.54 kB
`packages/contracts-js/factories/TWFee__factory/dist/thirdweb-dev-contracts-js-factories-TWFee__factory.cjs.js`	168 B
`packages/contracts-js/factories/TWFee__factory/dist/thirdweb-dev-contracts-js-factories-TWFee__factory.cjs.prod.js`	5.54 kB
`packages/contracts-js/factories/TWFee__factory/dist/thirdweb-dev-contracts-js-factories-TWFee__factory.esm.js`	5.49 kB
`packages/contracts-js/factories/TWMultichainRegistry__factory/dist/thirdweb-dev-contracts-js-factories-TWMultichainRegistry__factory.cjs.dev.js`	5.66 kB
`packages/contracts-js/factories/TWMultichainRegistry__factory/dist/thirdweb-dev-contracts-js-factories-TWMultichainRegistry__factory.cjs.js`	181 B
`packages/contracts-js/factories/TWMultichainRegistry__factory/dist/thirdweb-dev-contracts-js-factories-TWMultichainRegistry__factory.cjs.prod.js`	5.66 kB
`packages/contracts-js/factories/TWMultichainRegistry__factory/dist/thirdweb-dev-contracts-js-factories-TWMultichainRegistry__factory.esm.js`	5.6 kB
`packages/contracts-js/factories/TWProxy__factory/dist/thirdweb-dev-contracts-js-factories-TWProxy__factory.cjs.dev.js`	1.76 kB
`packages/contracts-js/factories/TWProxy__factory/dist/thirdweb-dev-contracts-js-factories-TWProxy__factory.cjs.js`	170 B
`packages/contracts-js/factories/TWProxy__factory/dist/thirdweb-dev-contracts-js-factories-TWProxy__factory.cjs.prod.js`	1.76 kB
`packages/contracts-js/factories/TWProxy__factory/dist/thirdweb-dev-contracts-js-factories-TWProxy__factory.esm.js`	1.7 kB
`packages/contracts-js/factories/TWRegistry__factory/dist/thirdweb-dev-contracts-js-factories-TWRegistry__factory.cjs.dev.js`	4.58 kB
`packages/contracts-js/factories/TWRegistry__factory/dist/thirdweb-dev-contracts-js-factories-TWRegistry__factory.cjs.js`	173 B
`packages/contracts-js/factories/TWRegistry__factory/dist/thirdweb-dev-contracts-js-factories-TWRegistry__factory.cjs.prod.js`	4.58 kB
`packages/contracts-js/factories/TWRegistry__factory/dist/thirdweb-dev-contracts-js-factories-TWRegistry__factory.esm.js`	4.53 kB
`packages/pay/dist/thirdweb-dev-pay.cjs.dev.js`	215 B
`packages/pay/dist/thirdweb-dev-pay.cjs.js`	148 B
`packages/pay/dist/thirdweb-dev-pay.cjs.prod.js`	215 B
`packages/pay/dist/thirdweb-dev-pay.esm.js`	123 B
`packages/pay/integrations/coinbase/dist/thirdweb-dev-pay-integrations-********.cjs.dev.js`	997 B
`packages/pay/integrations/coinbase/dist/thirdweb-dev-pay-integrations-********.cjs.js`	161 B
`packages/pay/integrations/coinbase/dist/thirdweb-dev-pay-integrations-********.cjs.prod.js`	997 B
`packages/pay/integrations/coinbase/dist/thirdweb-dev-pay-integrations-********.esm.js`	937 B
`packages/react/dist/defineProperty-********.cjs.dev.js`	416 B
`packages/react/dist/defineProperty-********.cjs.prod.js`	416 B
`packages/react/dist/defineProperty-********.esm.js`	403 B
`packages/react/dist/index-********.esm.js`	38.9 kB
`packages/react/dist/index-********.cjs.prod.js`	39 kB
`packages/react/dist/index-********.cjs.dev.js`	39.4 kB
`packages/react/dist/required-param-********.esm.js`	872 B
`packages/react/dist/required-param-********.cjs.dev.js`	978 B
`packages/react/dist/required-param-********.cjs.prod.js`	978 B
`packages/react/dist/thirdweb-dev-react.cjs.dev.js`	1.65 kB
`packages/react/dist/thirdweb-dev-react.cjs.js`	148 B
`packages/react/dist/thirdweb-dev-react.cjs.prod.js`	1.65 kB
`packages/react/dist/thirdweb-dev-react.esm.js`	1.36 kB
`packages/react/dist/useConnect-********.cjs.dev.js`	357 B
`packages/react/dist/useConnect-********.esm.js`	271 B
`packages/react/dist/useConnect-********.cjs.prod.js`	357 B
`packages/react/evm/connectors/gnosis-safe/dist/thirdweb-dev-react-evm-connectors-gnosis-safe.cjs.dev.js`	2.4 kB
`packages/react/evm/connectors/gnosis-safe/dist/thirdweb-dev-react-evm-connectors-gnosis-safe.cjs.js`	166 B
`packages/react/evm/connectors/gnosis-safe/dist/thirdweb-dev-react-evm-connectors-gnosis-safe.cjs.prod.js`	2.4 kB
`packages/react/evm/connectors/gnosis-safe/dist/thirdweb-dev-react-evm-connectors-gnosis-safe.esm.js`	2.08 kB
`packages/react/evm/connectors/magic/dist/thirdweb-dev-react-evm-connectors-magic.cjs.dev.js`	2.68 kB
`packages/react/evm/connectors/magic/dist/thirdweb-dev-react-evm-connectors-magic.cjs.js`	163 B
`packages/react/evm/connectors/magic/dist/thirdweb-dev-react-evm-connectors-magic.cjs.prod.js`	2.68 kB
`packages/react/evm/connectors/magic/dist/thirdweb-dev-react-evm-connectors-magic.esm.js`	2.37 kB
`packages/react/evm/dist/thirdweb-dev-react-evm.cjs.dev.js`	1.62 kB
`packages/react/evm/dist/thirdweb-dev-react-evm.cjs.js`	151 B
`packages/react/evm/dist/thirdweb-dev-react-evm.cjs.prod.js`	1.63 kB
`packages/react/evm/dist/thirdweb-dev-react-evm.esm.js`	1.36 kB
`packages/react/solana/dist/thirdweb-dev-react-solana.cjs.dev.js`	5.6 kB
`packages/react/solana/dist/thirdweb-dev-react-solana.cjs.js`	154 B
`packages/react/solana/dist/thirdweb-dev-react-solana.cjs.prod.js`	5.6 kB
`packages/react/solana/dist/thirdweb-dev-react-solana.esm.js`	5.3 kB
`packages/sdk/dist/defineProperty-********.cjs.dev.js`	416 B
`packages/sdk/dist/defineProperty-********.cjs.prod.js`	416 B
`packages/sdk/dist/defineProperty-********.esm.js`	403 B
`packages/sdk/dist/edition-********.cjs.dev.js`	3.04 kB
`packages/sdk/dist/edition-********.cjs.prod.js`	3.04 kB
`packages/sdk/dist/edition-********.esm.js`	3.1 kB
`packages/sdk/dist/edition-drop-********.cjs.dev.js`	3.45 kB
`packages/sdk/dist/edition-drop-********.cjs.prod.js`	3.45 kB
`packages/sdk/dist/edition-drop-********.esm.js`	3.53 kB
`packages/sdk/dist/marketplace-********.cjs.prod.js`	4.91 kB
`packages/sdk/dist/marketplace-********.esm.js`	4.89 kB
`packages/sdk/dist/marketplace-********.cjs.dev.js`	4.91 kB
`packages/sdk/dist/multiwrap-********.esm.js`	3.07 kB
`packages/sdk/dist/multiwrap-********.cjs.prod.js`	3.01 kB
`packages/sdk/dist/multiwrap-********.cjs.dev.js`	3.01 kB
`packages/sdk/dist/nft-collection-********.esm.js`	2.61 kB
`packages/sdk/dist/nft-collection-********.cjs.dev.js`	2.56 kB
`packages/sdk/dist/nft-collection-********.cjs.prod.js`	2.56 kB
`packages/sdk/dist/nft-drop-********.esm.js`	4.67 kB
`packages/sdk/dist/nft-drop-********.cjs.prod.js`	4.59 kB
`packages/sdk/dist/nft-drop-********.cjs.dev.js`	4.59 kB
`packages/sdk/dist/pack-********.esm.js`	4.78 kB
`packages/sdk/dist/pack-********.cjs.prod.js`	4.68 kB
`packages/sdk/dist/pack-********.cjs.dev.js`	4.68 kB
`packages/sdk/dist/QueryParams-********.cjs.prod.js`	1.5 kB
`packages/sdk/dist/QueryParams-********.cjs.dev.js`	1.5 kB
`packages/sdk/dist/QueryParams-********.esm.js`	1.39 kB
`packages/sdk/dist/sdk-********.cjs.prod.js`	19.4 kB
`packages/sdk/dist/sdk-********.esm.js`	19.1 kB
`packages/sdk/dist/sdk-********.cjs.dev.js`	19.4 kB
`packages/sdk/dist/signature-drop-********.cjs.prod.js`	4.19 kB
`packages/sdk/dist/signature-drop-********.esm.js`	4.26 kB
`packages/sdk/dist/signature-drop-********.cjs.dev.js`	4.18 kB
`packages/sdk/dist/split-********.esm.js`	2.87 kB
`packages/sdk/dist/split-********.cjs.prod.js`	2.94 kB
`packages/sdk/dist/split-********.cjs.dev.js`	2.94 kB
`packages/sdk/dist/thirdweb-checkout-********.cjs.prod.js`	111 kB
`packages/sdk/dist/thirdweb-checkout-********.esm.js`	109 kB
`packages/sdk/dist/thirdweb-checkout-********.cjs.dev.js`	111 kB
`packages/sdk/dist/thirdweb-dev-sdk.cjs.dev.js`	3.12 kB
`packages/sdk/dist/thirdweb-dev-sdk.cjs.js`	147 B
`packages/sdk/dist/thirdweb-dev-sdk.cjs.prod.js`	3.12 kB
`packages/sdk/dist/thirdweb-dev-sdk.esm.js`	2.67 kB
`packages/sdk/dist/token-********.cjs.prod.js`	2.4 kB
`packages/sdk/dist/token-********.esm.js`	2.45 kB
`packages/sdk/dist/token-********.cjs.dev.js`	2.4 kB
`packages/sdk/dist/token-drop-********.esm.js`	2.63 kB
`packages/sdk/dist/token-drop-********.cjs.prod.js`	2.6 kB
`packages/sdk/dist/token-drop-********.cjs.dev.js`	2.59 kB
`packages/sdk/dist/vote-********.cjs.dev.js`	3.69 kB
`packages/sdk/dist/vote-********.esm.js`	3.63 kB
`packages/sdk/dist/vote-********.cjs.prod.js`	3.69 kB
`packages/sdk/evm/dist/thirdweb-dev-sdk-evm.cjs.dev.js`	3.15 kB
`packages/sdk/evm/dist/thirdweb-dev-sdk-evm.cjs.js`	149 B
`packages/sdk/evm/dist/thirdweb-dev-sdk-evm.cjs.prod.js`	3.16 kB
`packages/sdk/evm/dist/thirdweb-dev-sdk-evm.esm.js`	2.71 kB
`packages/sdk/evm/wallets/dist/thirdweb-dev-sdk-evm-wallets.cjs.dev.js`	1.22 kB
`packages/sdk/evm/wallets/dist/thirdweb-dev-sdk-evm-wallets.cjs.js`	156 B
`packages/sdk/evm/wallets/dist/thirdweb-dev-sdk-evm-wallets.cjs.prod.js`	1.22 kB
`packages/sdk/evm/wallets/dist/thirdweb-dev-sdk-evm-wallets.esm.js`	1.14 kB
`packages/sdk/solana/dist/thirdweb-dev-sdk-solana.cjs.dev.js`	592 B
`packages/sdk/solana/dist/thirdweb-dev-sdk-solana.cjs.js`	153 B
`packages/sdk/solana/dist/thirdweb-dev-sdk-solana.cjs.prod.js`	594 B
`packages/sdk/solana/dist/thirdweb-dev-sdk-solana.esm.js`	498 B
`packages/sdk/solana/server/dist/thirdweb-dev-sdk-solana-server.cjs.dev.js`	1.2 kB
`packages/sdk/solana/server/dist/thirdweb-dev-sdk-solana-server.cjs.js`	157 B
`packages/sdk/solana/server/dist/thirdweb-dev-sdk-solana-server.cjs.prod.js`	1.2 kB
`packages/sdk/solana/server/dist/thirdweb-dev-sdk-solana-server.esm.js`	1.03 kB
`packages/storage/dist/thirdweb-dev-storage.cjs.dev.js`	6.72 kB
`packages/storage/dist/thirdweb-dev-storage.cjs.js`	149 B
`packages/storage/dist/thirdweb-dev-storage.cjs.prod.js`	6.71 kB
`packages/storage/dist/thirdweb-dev-storage.esm.js`	6.51 kB
`packages/unity-js-bridge/dist/thirdweb-unity-bridge.js`	788 kB
`packages/wallets/connectors/coinbase-wallet/dist/thirdweb-dev-wallets-connectors-coinbase-wallet.cjs.dev.js`	2.27 kB
`packages/wallets/connectors/coinbase-wallet/dist/thirdweb-dev-wallets-connectors-coinbase-wallet.cjs.js`	164 B
`packages/wallets/connectors/coinbase-wallet/dist/thirdweb-dev-wallets-connectors-coinbase-wallet.cjs.prod.js`	2.27 kB
`packages/wallets/connectors/coinbase-wallet/dist/thirdweb-dev-wallets-connectors-coinbase-wallet.esm.js`	2.04 kB
`packages/wallets/connectors/injected/dist/thirdweb-dev-wallets-connectors-********.cjs.dev.js`	2.77 kB
`packages/wallets/connectors/injected/dist/thirdweb-dev-wallets-connectors-********.cjs.js`	162 B
`packages/wallets/connectors/injected/dist/thirdweb-dev-wallets-connectors-********.cjs.prod.js`	2.77 kB
`packages/wallets/connectors/injected/dist/thirdweb-dev-wallets-connectors-********.esm.js`	2.75 kB
`packages/wallets/connectors/metamask/dist/thirdweb-dev-wallets-connectors-********.cjs.dev.js`	1.73 kB
`packages/wallets/connectors/metamask/dist/thirdweb-dev-wallets-connectors-********.cjs.js`	164 B
`packages/wallets/connectors/metamask/dist/thirdweb-dev-wallets-connectors-********.cjs.prod.js`	1.73 kB
`packages/wallets/connectors/metamask/dist/thirdweb-dev-wallets-connectors-********.esm.js`	1.68 kB
`packages/wallets/connectors/wallet-connect/dist/thirdweb-dev-wallets-connectors-wallet-connect.cjs.dev.js`	2.23 kB
`packages/wallets/connectors/wallet-connect/dist/thirdweb-dev-wallets-connectors-wallet-connect.cjs.js`	161 B
`packages/wallets/connectors/wallet-connect/dist/thirdweb-dev-wallets-connectors-wallet-connect.cjs.prod.js`	2.23 kB
`packages/wallets/connectors/wallet-connect/dist/thirdweb-dev-wallets-connectors-wallet-connect.esm.js`	1.99 kB
`packages/wallets/dist/classPrivateFieldGet-********.esm.js`	769 B
`packages/wallets/dist/classPrivateFieldGet-********.cjs.dev.js`	788 B
`packages/wallets/dist/classPrivateFieldGet-********.cjs.prod.js`	788 B
`packages/wallets/dist/classPrivateMethodGet-********.cjs.prod.js`	285 B
`packages/wallets/dist/classPrivateMethodGet-********.esm.js`	264 B
`packages/wallets/dist/classPrivateMethodGet-********.cjs.dev.js`	286 B
`packages/wallets/dist/storage-********.cjs.prod.js`	437 B
`packages/wallets/dist/storage-********.esm.js`	342 B
`packages/wallets/dist/storage-********.cjs.dev.js`	437 B
`packages/wallets/dist/thirdweb-dev-wallets.cjs.dev.js`	392 B
`packages/wallets/dist/thirdweb-dev-wallets.cjs.js`	149 B
`packages/wallets/dist/thirdweb-dev-wallets.cjs.prod.js`	391 B
`packages/wallets/dist/thirdweb-dev-wallets.esm.js`	254 B
`packages/wallets/wallets/base/dist/thirdweb-dev-wallets-wallets-base.cjs.dev.js`	2.75 kB
`packages/wallets/wallets/base/dist/thirdweb-dev-wallets-wallets-base.cjs.js`	155 B
`packages/wallets/wallets/base/dist/thirdweb-dev-wallets-wallets-base.cjs.prod.js`	2.75 kB
`packages/wallets/wallets/base/dist/thirdweb-dev-wallets-wallets-base.esm.js`	2.67 kB
`packages/wallets/wallets/coinbase-wallet/dist/thirdweb-dev-wallets-wallets-coinbase-wallet.cjs.dev.js`	651 B
`packages/wallets/wallets/coinbase-wallet/dist/thirdweb-dev-wallets-wallets-coinbase-wallet.cjs.js`	159 B
`packages/wallets/wallets/coinbase-wallet/dist/thirdweb-dev-wallets-wallets-coinbase-wallet.cjs.prod.js`	651 B
`packages/wallets/wallets/coinbase-wallet/dist/thirdweb-dev-wallets-wallets-coinbase-wallet.esm.js`	563 B
`packages/wallets/wallets/injected/dist/thirdweb-dev-wallets-wallets-********.cjs.dev.js`	636 B
`packages/wallets/wallets/injected/dist/thirdweb-dev-wallets-wallets-********.cjs.js`	158 B
`packages/wallets/wallets/injected/dist/thirdweb-dev-wallets-wallets-********.cjs.prod.js`	636 B
`packages/wallets/wallets/injected/dist/thirdweb-dev-wallets-wallets-********.esm.js`	550 B
`packages/wallets/wallets/metamask/dist/thirdweb-dev-wallets-wallets-********.cjs.dev.js`	624 B
`packages/wallets/wallets/metamask/dist/thirdweb-dev-wallets-wallets-********.cjs.js`	158 B
`packages/wallets/wallets/metamask/dist/thirdweb-dev-wallets-wallets-********.cjs.prod.js`	625 B
`packages/wallets/wallets/metamask/dist/thirdweb-dev-wallets-wallets-********.esm.js`	539 B
`packages/wallets/wallets/wallet-connect/dist/thirdweb-dev-wallets-wallets-wallet-connect.cjs.dev.js`	619 B
`packages/wallets/wallets/wallet-connect/dist/thirdweb-dev-wallets-wallets-wallet-connect.cjs.js`	158 B
`packages/wallets/wallets/wallet-connect/dist/thirdweb-dev-wallets-wallets-wallet-connect.cjs.prod.js`	620 B
`packages/wallets/wallets/wallet-connect/dist/thirdweb-dev-wallets-wallets-wallet-connect.esm.js`	535 B

_{compressed-size-action}

packages/cli/src/cli/index.ts

adam-maj · 2022-12-03T02:59:59Z

/release-pr

jnsdls

all of this is scary

packages/cli/src/cli/index.ts

adam-maj · 2022-12-03T03:55:19Z

/release-pr

adam-maj · 2022-12-03T04:18:36Z

/release-pr

adam-maj · 2022-12-03T05:12:15Z

Tested with both npm and yarn (should be same setup for pnpm as well), and on replit - all work as expected.

adam-maj · 2022-12-03T05:12:38Z

And also when there is a local installation of the thirdweb package, vs global

adam-maj · 2022-12-03T05:13:09Z

Would be good to get one other confirmation on this given the nature of the changes

adam-maj · 2022-12-03T05:14:23Z

Everything should work on this version 0.9.3-dev-d5b649c (if you install it locally or globally, and then run npx thirdweb deploy or anything else, it should auto-upgrade properly and run the command successfully all at once, regardless of package manager.

adam-maj · 2022-12-06T00:28:12Z

/release-pr

adam-maj · 2022-12-06T00:54:48Z

/release-pr

adam-maj · 2022-12-06T01:33:22Z

/release-pr

adam-maj · 2022-12-06T02:02:32Z

/release-pr

adam-maj · 2022-12-06T02:15:30Z

/release-pr

adam-maj · 2022-12-06T02:21:27Z

I've accounted for + successfully tested all the edge cases:

Local installation with npm
Local installation with yarn
Local installation with pnpm
Global installation with npm
Global installation with yarn (doesn't get picked up by npx, so only gets hit if you run thirdweb directly)
Global installation with pnpm (doesn't get picked up by npx, so only gets hit if you run thirdweb directly)
No installation, defaults to thirdweb@latest - but you already have that version cached
No installation, defaults to thirdweb@latest, you don't have it cached so it needs to install (but we're passing --yes flag so you don't see the prompt)

I think we should be good to go

adam-maj · 2022-12-06T02:25:12Z

The code path is:

Check for local installation, if it's there, get the package manager
Otherwise check for global installation on all 3 package managers
Otherwise , just default to npx thirdweb@latest (and auto-accept install)

jnsdls

1 last thing that stands out to me, then I think we're good?

packages/cli/src/cli/index.ts

Fixed

adam-maj and others added 4 commits December 2, 2022 12:01

[CLI] Make solc default backup compilation

1a5b163

Add changeset

8de803f

Merge branch 'main' into am/cli

c8f3881

CLI auto-updates on every run

5afb56c

adam-maj and others added 7 commits December 2, 2022 17:27

Update

86f2283

Merge branch 'main' into am/cli

f309e50

Update

0825d37

Merge branch 'am/cli' of https://github.com/thirdweb-dev/js into am/cli

0861ca9

Remove shelljs

1b661e6

Add changeset

c2b20ee

Update package.json

121fa4a

Switch back package.json

00ad963

adam-maj added 2 commits December 2, 2022 17:40

Merge branch 'main' into am/cli

a179b38

Merge branch 'main' into am/cli

8dd0195

joaquim-verges reviewed Dec 3, 2022

View reviewed changes

packages/cli/src/cli/index.ts Outdated Show resolved Hide resolved

packages/cli/src/cli/index.ts Outdated Show resolved Hide resolved

adam-maj and others added 2 commits December 2, 2022 21:58

Merge branch 'main' into am/cli

47d7ed4

Lower package version

725330f

jnsdls reviewed Dec 3, 2022

View reviewed changes

packages/cli/src/cli/index.ts Outdated Show resolved Hide resolved

packages/cli/src/cli/index.ts Outdated Show resolved Hide resolved

packages/cli/src/cli/index.ts Outdated Show resolved Hide resolved

adam-maj added 2 commits December 2, 2022 22:44

Install by package manager

62f87dc

Extract out local package detection

5622835

Reset versio

d5b649c

adam-maj added 2 commits December 3, 2022 00:11

Update package version

569ac86

Update packages

21ed6c5

adam-maj and others added 3 commits December 5, 2022 16:55

Merge branch 'main' into am/cli

a87f3ec

Merge branch 'main' into am/cli

4d57123

Catch cases for global install

58ac7aa

adam-maj added 2 commits December 5, 2022 19:37

Update version

2cea325

Fix pnpm edge case

504eaff

adam-maj added 2 commits December 5, 2022 20:12

Update package.json

b05c6ad

Update to account for all cases

272b1f0

adam-maj added 2 commits December 5, 2022 20:41

Update package.json version

32bec49

Update again :(

b02274f

Automatically accept install npx

5bec267

Update package version

fab2a9a

jnsdls previously requested changes Dec 6, 2022

View reviewed changes

packages/cli/src/cli/index.ts Outdated Show resolved Hide resolved

Add default case for package manager

c58ec99

adam-maj enabled auto-merge (squash) December 6, 2022 02:34

adam-maj merged commit 64f24f1 into main Dec 6, 2022

adam-maj deleted the am/cli branch December 6, 2022 02:40

github-actions bot mentioned this pull request Dec 6, 2022

Version Packages #449

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CLI auto-updates on every run #441

CLI auto-updates on every run #441

adam-maj commented Dec 2, 2022

changeset-bot bot commented Dec 2, 2022 •

edited

adam-maj commented Dec 2, 2022

github-actions bot commented Dec 2, 2022 •

edited

adam-maj commented Dec 3, 2022

jnsdls left a comment

adam-maj commented Dec 3, 2022

adam-maj commented Dec 3, 2022

adam-maj commented Dec 3, 2022

adam-maj commented Dec 3, 2022

adam-maj commented Dec 3, 2022

adam-maj commented Dec 3, 2022

adam-maj commented Dec 6, 2022

adam-maj commented Dec 6, 2022

adam-maj commented Dec 6, 2022

adam-maj commented Dec 6, 2022

adam-maj commented Dec 6, 2022

adam-maj commented Dec 6, 2022

adam-maj commented Dec 6, 2022

jnsdls left a comment

CLI auto-updates on every run #441

CLI auto-updates on every run #441

Conversation

adam-maj commented Dec 2, 2022

changeset-bot bot commented Dec 2, 2022 • edited

🦋 Changeset detected

adam-maj commented Dec 2, 2022

github-actions bot commented Dec 2, 2022 • edited

adam-maj commented Dec 3, 2022

jnsdls left a comment

Choose a reason for hiding this comment

adam-maj commented Dec 3, 2022

adam-maj commented Dec 3, 2022

adam-maj commented Dec 3, 2022

adam-maj commented Dec 3, 2022

adam-maj commented Dec 3, 2022

adam-maj commented Dec 3, 2022

adam-maj commented Dec 6, 2022

adam-maj commented Dec 6, 2022

adam-maj commented Dec 6, 2022

adam-maj commented Dec 6, 2022

adam-maj commented Dec 6, 2022

adam-maj commented Dec 6, 2022

adam-maj commented Dec 6, 2022

jnsdls left a comment

Choose a reason for hiding this comment

changeset-bot bot commented Dec 2, 2022 •

edited

github-actions bot commented Dec 2, 2022 •

edited