[SDK] Fix deploy transaction listener for all deploy types sdk.deployer.addDeployListener()
#494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dDeployListener()`
🦋 Changeset detectedLatest commit: c6455c7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +202 B (0%) Total Size: 3.62 MB ℹ️ View Unchanged
|
This was referenced Jan 14, 2023
Merged
|
Thanks @joaquim-verges . Still i need to go deeper in understanding all the huge code there :) So i tried to make a not invasive fix in order to break nothing.... so thank you for your PR and happy to help in any way... I forked and checked this new version. The problem is the tx hash is only coming at the end of deployment. But still need a solution to provide "submitted" event before wait for confirmations. The whole reason for this is to get the transaction hash early on, so we can react... in edge cases like user leaving the dapp, or his connections breaks etc... this way ... we know what transaction to follow when we get back.... so the idea is to:
I created a new PR with the fix for this, please check and let me to know Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now works with all deploy types - factory/proxy/direct
API is simpler too:
sdk.deployer.addDeployListener((event) => console.log(event)}