Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update product.tpl #6

Closed
wants to merge 2 commits into from
Closed

Conversation

Nobodaddy
Copy link
Contributor

Added variable to suppress by default the conditions display

Added variable to suppress by default the conditions display
@Dh42
Copy link
Contributor

Dh42 commented Jun 25, 2017

Is there anything to control this?

@Nobodaddy
Copy link
Contributor Author

Pardon? I don't understand your question. My proposed changes just provide an option to hide the conditions display on the product details page. There are no dependencies.
Makes it easier for merchants who had to comment out directly the relevant code snippet in Product.tpl to reach the same result, until now.

@Traumflug
Copy link
Contributor

This pull request makes more sense with the other three you provided at the same time, doesn't it?

If possible, it's usually a good idea to put related patches/commit into a single pull request. Github happily accepts PRs with 100 commits.

@Nobodaddy
Copy link
Contributor Author

@Traumflug
I totally agree, but although I made a lot of commits during the past years, I'm still a Github dummy. I simply do not know how to put these patches into a single pull request.

@Traumflug
Copy link
Contributor

It works best by kicking out these Github "helper" tools out of the window :-) Using command-line Git and Gitk --all for viewing the results.

Anyways, the other patches are in a different repository anyways, so putting them into one PR isn't possible. But referencing them is: thirtybees/thirtybees#260

product.tpl Outdated
@@ -108,7 +108,8 @@
<span class="editable" itemprop="sku"{if !empty($product->reference) && $product->reference} content="{$product->reference}"{/if}>{if !isset($groups)}{$product->reference|escape:'html':'UTF-8'}{/if}</span>
</p>

{if !$product->is_virtual && $product->condition}
<!-- added variable to suppress by default the conditions display -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unusual to put such comment into HTML. A diff like shown here nicely shows the change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! :)

removed comment. :)
@Traumflug
Copy link
Contributor

Made a commit from the pieces here and pushed that: 6dfd9d0

Thank you very much!

@Traumflug Traumflug closed this Jun 25, 2017
@Dh42
Copy link
Contributor

Dh42 commented Jun 25, 2017

Thanks for your contribution @Nobodaddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants