New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update product.tpl #6
Conversation
Added variable to suppress by default the conditions display
Is there anything to control this? |
Pardon? I don't understand your question. My proposed changes just provide an option to hide the conditions display on the product details page. There are no dependencies. |
This pull request makes more sense with the other three you provided at the same time, doesn't it? If possible, it's usually a good idea to put related patches/commit into a single pull request. Github happily accepts PRs with 100 commits. |
@Traumflug |
It works best by kicking out these Github "helper" tools out of the window :-) Using command-line Anyways, the other patches are in a different repository anyways, so putting them into one PR isn't possible. But referencing them is: thirtybees/thirtybees#260 |
product.tpl
Outdated
@@ -108,7 +108,8 @@ | |||
<span class="editable" itemprop="sku"{if !empty($product->reference) && $product->reference} content="{$product->reference}"{/if}>{if !isset($groups)}{$product->reference|escape:'html':'UTF-8'}{/if}</span> | |||
</p> | |||
|
|||
{if !$product->is_virtual && $product->condition} | |||
<!-- added variable to suppress by default the conditions display --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unusual to put such comment into HTML. A diff like shown here nicely shows the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! :)
removed comment. :)
Made a commit from the pieces here and pushed that: 6dfd9d0 Thank you very much! |
Thanks for your contribution @Nobodaddy |
Added variable to suppress by default the conditions display