Inconsistent configuration tests

[roband7]

I'm assuming the intention is that he implementation and 'owner' of these tests is classes/ConfigurationTest.php

The problem is that a lot of the knowledge of test result array keys, and all the error texts, are duplicated in controllers/admin/AdminInformationController.php and install/controllers/http/system.php

Right now system.php seem to be in sync with ConfigurationTest.php, but AdminInformationController.php isn't.

The need for syncing and the duplication of error texts is silly and error-prone.

My suggestion is to move all the logic and and texts over to ConfigurationTest.php and slim down AdminInformationController.php and system.php

Also, if you do a command-line install using install/index_cli.php it doesn't call ConfigurationTest.php at all, bypassing all the tests! Yes, I learned this the hard way, and was why I started digging into this mess :)

[firstred]

Thanks. It is indeed something we want to take care of, but it currently requires too many changes for a patch version. Rescheduling for 1.1.0 instead.

[firstred]

Just a basic solution for now, not very verbose: e08c47c

[Traumflug]

This area received a lot of smaller improvements over the last year. AFAIK the only issue left is the distribution of tests and their messages over several places. Installer, AdminInformationController, ConfigurationTest and last not least the place where all this should go: module Core Updater with its AdminCoreUpdaterController.