Cannot choose carrier on checkout page

[dosbiner]

hi, after upgrade to 1.0.5 I can't choose carrier on checkout page. I make gif for showing it https://prnt.sc/k4ua56

debug mode on showing this error:
Notice: Undefined variable: delivery_option in /home/dev/webapps/dev11/classes/Cart.php on line 1039

I replace Cart.php from 1.0.4 and then the problem gone, but I think its just temporary solution for me.

I've tried both on production site and fresh tb 1.0.5.
Nginx
PHP 7.2.5
MariaDB

[Traumflug]

First, thanks for reporting!

Hmm. There is only one commit changing this file between 1.0.4 and 1.0.5: e7095a7

[Traumflug]

I think I caught it: 05997b6

Would you be kind enough to test this version of Cart.php? https://raw.githubusercontent.com/thirtybees/thirtybees/05997b6feea465031d639fe1ac006105298d03f8/classes/Cart.php

[dosbiner]

error not showing anymore, but still cannot choose the carrier. have tried to switch php 7.0, 7.1, and switch to apache+nginx, still cannot choose the carrier

[Traumflug]

Then there's another problem :-) I'll experiment a bit myself.

[Traumflug]

Hmm. It works fine in my local installation, the radio buttons stick.

As these buttons jump back immediately, it might be some JavaScript problem. Can you enable the web console (Firefox: hit F12) and look for messages there?

[dosbiner]

there are no error logs in console, I have tried Firefox and Chrome.
I send you message on TB forum the url site, BO Access, and FTP access if you need to check the problem

[Traumflug]

Thanks for the credentials.

• Went to the front office page.
• Clicked on product Coffee.
• Clicked "Add to cart"
• Clicked "Proceed to checkout"
• Scrolled down to Delivery methods, ignoring all the login and address stuff.
• Clicked on various radio buttons, each one sticks.

Then I uploaded classes/Cart.php from Git tag 1.0.5, reloaded the page and did see the selection jumping back.

Then I uploaded classes/Cart.php from current 1.0.x (which matches that of branch carrier of yesterday), reloaded the web page and the problem no longer happened. Carriers stick again.

Conclusion: your shop works just fine.

If it still doesn't for you, I'd simply put this aside for a week. There are certainly other things to do. Internet stuff has sometimes self healing magic.

[getdatakick]

I can reproduce this issue as well. This is an injection from commit e7095a7

The problem is on line 1037

json_decode($this->delivery_option);

returns object instead of array (which is expected in code later )

Fix is fairy simple:

json_decode($this->delivery_option, true);

[dosbiner]

wow you right, its working now, thank you datakick 👍
this issue solved now @Traumflug

[Traumflug]

Excellent!

As you can see by the commits mentioned above, I extended this finding to an audit of all json_decode() usages. Which resulted in quite a few edits.

Closing, as the issue is solved. If there's anything left, don't hesitate to reopen it.

[drudesign]

Having same issue with up to date Cart.php file - any ideas?

[getdatakick]

@drudesign I believe that's already fixed by cf7adb2

[drood89]

Hello. I have the same problem. I checked the solution:
cf7adb2

Did not help. I still had:

Notice: Undefined variable: delivery_option in /home/modwork-io/web/as1.modwork.io/public_html/classes/Cart.php on line 1039

I checked the file:

https://raw.githubusercontent.com/thirtybees/thirtybees/05997b6feea465031d639fe1ac006105298d03f8/classes/Cart.php

And that solved the problem.