Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multistore: incorrect hreflang links #848

Closed
getdatakick opened this issue Feb 15, 2019 · 1 comment
Closed

Multistore: incorrect hreflang links #848

getdatakick opened this issue Feb 15, 2019 · 1 comment

Comments

@getdatakick
Copy link
Contributor

Reported here.

Thirtybees has a feature to emit hreflang links. This feature does not work correctly when multistore is enabled, and each store uses different set of languages. In this scenario, hreflang links for languages used by different stores are emitted as well.

We could also implement a switch to turn off this feature, and a hook to alter alt links just before they get rendered to the html.

getdatakick added a commit that referenced this issue Feb 15, 2019
getSeoFields method can return invalid result when multistore is enabled
and different set of languages is used by individual stores.

Related to issue #848
@getdatakick
Copy link
Contributor Author

The issue itself is fixed by 97a57be. I will keep this opened for the enhancement part - switch and hook

getdatakick added a commit that referenced this issue Feb 15, 2019
use TB_EMIT_SEO_FIELDS configuration value to decide whether to render
additional seo metadata fields into the page header.

This impacts:
- canonical link: <link rel="canonical" href="http://domain.com/en/">
- hreflang links: <link rel="alternate" href="http://domain.com/cs/" hreflang="cs-cz">
- pagination prev and next links: <link rel="prev" href="http://domain.com/en/category?p=2">

Related to issue #848
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant