Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translations not saving #976

Closed
Traumflug opened this issue Jun 25, 2019 · 3 comments
Closed

Translations not saving #976

Traumflug opened this issue Jun 25, 2019 · 3 comments

Comments

@Traumflug
Copy link
Contributor

See https://forum.thirtybees.com/topic/3152-translations-not-saving

If I try and make a translation change of any sort, it doesn't work. Sometimes it shows in the translation mod UI, and sometimes not. I haven't found a pattern there. The only constant is that after clearing cache and reloading the affected web site pages, the translations are not taking. I check the translation file on the backend and it doesn't have my modifications included either.

I'm referring to the UI within thirtybees back office. If I make adjustments to translations there, they do not save to a translations file as they should on a regular basis.
@yaniv14
Copy link
Contributor

yaniv14 commented Jun 25, 2019

I think its related #958

@getdatakick
Copy link
Contributor

Maybe, but #958 is not in 1.0.8 -- it affects bleeding edge / 1.1.x only. I've asked creator of the thread to confirm his version

@getdatakick
Copy link
Contributor

x97wehner confirmed he's on bleeding edge, so it's extremely likely this is related to, or even duplicate of issue #958

@getdatakick getdatakick reopened this Jun 8, 2020
eschiendorfer pushed a commit to eschiendorfer/thirtybees that referenced this issue Jul 28, 2020
@getdatakick @eschiendorfer
Translations: fix vanishing translation
9848e37 
Since 1.1.0 translations are saved per section. Thirtybees first clears
all translation from given section, and then import new translations
submitted in form.

The clearing mechanism works on prefix bases. If other section starts
with the same prefix, its entries would be removed as well. For example,
saving `authentication` section would remove all translations from
sections `authentication-login` or `authentication-create`.

The fix is simple -- don't clear translations at all. Remove only
entries if the input post value contain empty string.

Closes thirtybees#976
eschiendorfer pushed a commit to eschiendorfer/thirtybees that referenced this issue Jul 28, 2020
@getdatakick @eschiendorfer
Translations: fix vanishing translation
46bb213 
Since 1.1.0 translations are saved per section. Thirtybees first clears
all translation from given section, and then import new translations
submitted in form.

The clearing mechanism works on prefix bases. If other section starts
with the same prefix, its entries would be removed as well. For example,
saving `authentication` section would remove all translations from
sections `authentication-login` or `authentication-create`.

The fix is simple -- don't clear translations at all. Remove only
entries if the input post value contain empty string.

Closes thirtybees#976
eschiendorfer pushed a commit to eschiendorfer/thirtybees that referenced this issue Jul 29, 2020
@getdatakick @eschiendorfer
Translations: fix vanishing translation
ebbf1a4 
Since 1.1.0 translations are saved per section. Thirtybees first clears
all translation from given section, and then import new translations
submitted in form.

The clearing mechanism works on prefix bases. If other section starts
with the same prefix, its entries would be removed as well. For example,
saving `authentication` section would remove all translations from
sections `authentication-login` or `authentication-create`.

The fix is simple -- don't clear translations at all. Remove only
entries if the input post value contain empty string.

Closes thirtybees#976
eschiendorfer pushed a commit to eschiendorfer/thirtybees that referenced this issue Jul 29, 2020
@getdatakick @eschiendorfer
Translations: fix vanishing translation
758339e 
Since 1.1.0 translations are saved per section. Thirtybees first clears
all translation from given section, and then import new translations
submitted in form.

The clearing mechanism works on prefix bases. If other section starts
with the same prefix, its entries would be removed as well. For example,
saving `authentication` section would remove all translations from
sections `authentication-login` or `authentication-create`.

The fix is simple -- don't clear translations at all. Remove only
entries if the input post value contain empty string.

Closes thirtybees#976
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Traumflug @yaniv14 @getdatakick