New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically check/set the time on cameras, and bump timeout #54
Conversation
This, combined with auto time set, should completely fix #14.
@hh1209 can you download the prebuilt for this PR and see if this fixes the bootlooping camera problem? Stress test as best you can. |
One thing I noticed is if the cams have internet access, they'll auto set their times via NTP very quickly after you try to change it with the set_time API call. |
@QuantumEntangledAndy I'd appreciate a code review since you're rapidly getting familiar with the project. |
p.s. Are you sure I should be code reviewing I don't feel like my rust foo is of any great level |
This sets the time twice if you have |
Just a thought, what if someone is only using one stream, like on 400 series cams? i.e. not the "management" stream |
Neolink would ensure one of the connections is always a management connection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All seems to be working in my testing. I can reboot, autoreboot, yank cables, etc and it doesn't blink or try to loop reconnect.
This is a great feature for those who don't want their cameras on the internet
Automatically check/set the time on cameras, and bump timeout
Collectively, this should close #14.