-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ubuntu, buster-arm, fedora, macos and windows packaging #66
Add ubuntu, buster-arm, fedora, macos and windows packaging #66
Conversation
Thanks for this. Sorry I've been quiet for a while, I just bought a house and I'm in the process of moving in. I will try to review Real Soon Now :) |
Congratulations :). Take your time, moving in takes much longer than we think :). Also I'm planning to add a window msi using cargo Wix too then we will have all the OSes. |
8b32aac
to
1d45de0
Compare
So I am trying to setup a windows test environment in Virtual Box. I am having trouble building neolink, as I cannot seem to link glib2 any idea how to resolve this? I've gotten the libraries installed but I am not sure how to set the library search path on windows... sigh |
Nevermind I got glib and gobject to work but I am struggling to link gstreamer now... The same method I used for glib dosen't seem to work for gstreamer fyi to those interested used this in the [target.x86_64-pc-windows-msvc.glib]
rustc-link-search = ["C:\\Program Files (x86)\\GTK2-Runtime\\bin"]
[target.x86_64-pc-windows-msvc.gobject]
rustc-link-search = ["C:\\Program Files (x86)\\GTK2-Runtime\\bin"] |
Ok I had to add |
b364c7b
to
9932db6
Compare
I think I have a working msi for neolink, only I couldn't get the dependency check on gstreamer to work correctly. Will look into it when I can |
Windows lacks the sed command by default, so just use powershell functions instead
183ef4d
to
f2153ee
Compare
Given our discussion in #59 I am swapping the mac build to use the pkg from gstreamer (since the pkg installer this PR makes for neolink explicitly searches for it in /Library/Framework/Gstreamer.framework) |
8bfd802
to
cf2e71b
Compare
cf2e71b
to
90ca154
Compare
So I am relatively happy with how this is working. There is a further imporement that we could do:
This would mean that we would need to ship it bundled together with gstreamer
This will mean that it will bump up the size of our packages by about 100-200MB |
The sanctioned approach for WiX is to use the merge module that Gstreamer ships with their dev package. The merge module will literally merge with the MSI and become a single installable. I've done it before for the MSVC runtime; it's quite clean. I don't have a strong opinion about the Mac pkg yet. |
I originally planned to extract the pkg components from the runtime deployment pkg and use them. But they are not valid outside of the bundle so we have to deploy the whole gstreamer app.
|
In terms of adding services would you be ok with using nssm or would you prefer to go down the rust https://github.com/mullvad/windows-service-rs route and implement the expected functions directly into neolink |
fdd4931
to
28a5e6c
Compare
28a5e6c
to
341276c
Compare
With no progress on my PRs in years I am closing them in favour of working on my own fork |
…fix/mqtt_asyncio Update mqtt to use tokio
This adds packages for various distros of linux and macos.
The debian packages are made with cargo-deb and the fedora with cargo-rpm
The macos package waa originally a homebrew tab but I have since swapped it to a PKG (installer).
Useage
Debian, (ubuntu amd64/buster armhf)
Fedora (amd64)
Macos
Windows
Closes #61
Closes #1 🎉 (well not the service part but that should be on the todo list)