Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TS typings #19

Merged
merged 12 commits into from
Jan 9, 2022
Merged

Conversation

areknawo
Copy link
Contributor

This PR adds TS typings with the following code changes:

  • reduce the use of undefined in favor of null (consistency & easier typing)
  • use multiple parameters instead of objects where appropriate (easier typing)
  • use .ts extensions where TSX is not required
  • use single export at the bottom of the file (consistency, readability)
  • rename DragDropContext and SortableContext to DragDropProvider and SortableProvider respectively (in-line with Solid.js naming practices)

⚠️ Changes in naming are breaking.

@martinpengellyphillips
Copy link
Contributor

Great to see this @areknawo. I see you are still adding a few commits - let me know when you want me to do a first pass review and I'll jump in.

@areknawo
Copy link
Contributor Author

I've done some tests with all the examples from the docs and it's all good now. I think you can do the first pass now.

Copy link
Contributor

@martinpengellyphillips martinpengellyphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - thanks again for the work here. I've tested with a few of my sites now and only found a few issues (see comments on files).

I'll give you some time to respond, but if you are busy just let me know - I can always merge and then make the decisions/changes myself before release.

Notes to self:

  • We should add you as a contributor somewhere - perhaps in the README or a CONTRIBUTORS.md file.
  • Update README.md to reflect changes.
  • Update CHANGELOG with changes. In particular, highlight breaking changes of renames and the changes to function parameters style.
  • Fix min SolidJS version compatibility to be >= 1.0.5

.vscode/settings.json Outdated Show resolved Hide resolved
src/layout.ts Show resolved Hide resolved
src/drag-drop-context.tsx Show resolved Hide resolved
src/drag-drop-context.tsx Show resolved Hide resolved
src/create-pointer-sensor.ts Outdated Show resolved Hide resolved
src/drag-drop-context.tsx Show resolved Hide resolved
src/create-draggable.ts Show resolved Hide resolved
src/create-draggable.ts Outdated Show resolved Hide resolved
src/create-draggable.ts Show resolved Hide resolved
src/drag-drop-context.tsx Show resolved Hide resolved
@martinpengellyphillips
Copy link
Contributor

Okay - I think everything is done (including CHANGELOG and README updates).

I'll do one more test later today with my repos and then merge and release by end of this week. Thank you again for all the help!!

@martinpengellyphillips martinpengellyphillips merged commit 067d9ea into thisbeyond:main Jan 9, 2022
@martinpengellyphillips martinpengellyphillips mentioned this pull request Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants