-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement TS typings #19
Conversation
Great to see this @areknawo. I see you are still adding a few commits - let me know when you want me to do a first pass review and I'll jump in. |
I've done some tests with all the examples from the docs and it's all good now. I think you can do the first pass now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good - thanks again for the work here. I've tested with a few of my sites now and only found a few issues (see comments on files).
I'll give you some time to respond, but if you are busy just let me know - I can always merge and then make the decisions/changes myself before release.
Notes to self:
- We should add you as a contributor somewhere - perhaps in the README or a CONTRIBUTORS.md file.
- Update README.md to reflect changes.
- Update CHANGELOG with changes. In particular, highlight breaking changes of renames and the changes to function parameters style.
- Fix min SolidJS version compatibility to be >= 1.0.5
Note: onDragEnd signature may need updating following decision from https://github.com/thisbeyond/solid-dnd/pull/19/files#r778940266
Okay - I think everything is done (including CHANGELOG and README updates). I'll do one more test later today with my repos and then merge and release by end of this week. Thank you again for all the help!! |
This PR adds TS typings with the following code changes:
undefined
in favor ofnull
(consistency & easier typing)export
at the bottom of the file (consistency, readability)DragDropContext
andSortableContext
toDragDropProvider
andSortableProvider
respectively (in-line with Solid.js naming practices)