Skip to content

Commit

Permalink
fix(component): setPlaceholder called in Angular onChanges life cylce…
Browse files Browse the repository at this point in the history
… hook

setPlaceholder called in Angular onChanges life cylce hook to prevent angular reusing stale rendered
image when component image data changes.
  • Loading branch information
jackhkmatthews committed Mar 1, 2018
1 parent 236a9e9 commit 2006718
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 2 deletions.
Expand Up @@ -212,4 +212,10 @@ describe('ImageLoaderComponent', () => {
component.checkInViewportStatus();
expect(spy).toHaveBeenCalled();
});

it('should set placeholder on changes', () => {
const spy = spyOn(component, 'setPlaceholder');
component.ngOnChanges();
expect(spy).toHaveBeenCalled();
});
});
15 changes: 13 additions & 2 deletions src/app/image-loader/image-loader/image-loader.component.ts
Expand Up @@ -10,7 +10,8 @@ import {
OnDestroy,
ViewChild,
ElementRef,
NgZone
NgZone,
OnChanges
} from '@angular/core';
import { Subject } from 'rxjs/Subject';
import { Observable } from 'rxjs/Observable';
Expand Down Expand Up @@ -50,7 +51,7 @@ import {
templateUrl: './image-loader.component.html',
styleUrls: [ './image-loader.component.scss' ]
})
export class ImageLoaderComponent implements OnInit, AfterViewInit, OnDestroy {
export class ImageLoaderComponent implements OnInit, AfterViewInit, OnDestroy, OnChanges {
/**
* URL of image for `img` element to display
* @memberof ImageLoaderComponent
Expand Down Expand Up @@ -331,4 +332,14 @@ export class ImageLoaderComponent implements OnInit, AfterViewInit, OnDestroy {
this.ngUnsubscribe$.next();
this.ngUnsubscribe$.complete();
}
/**
* Trigger image preload on changes.
* Prevents angular from reusing rendered image
* after changes.
*
* @memberof ImageLoaderComponent
*/
public ngOnChanges(): void {
this.setPlaceholder();
}
}

0 comments on commit 2006718

Please sign in to comment.