Merge pull request #10 from thisissoon/feature/fix-deleting-meta

Fix: meta data being deleted when not specified in route
thisissoon · Nov 25, 2015 · 3dac709 · 3dac709
2 parents 8bee9ad + 52e8b83
commit 3dac709
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/app/js/meta.js b/app/js/meta.js
@@ -112,9 +112,8 @@ angular.module('sn.meta', ['ngRoute'])
               current.$$route.meta[ $attrs[keyAttr] ]
           ) {
             content = current.$$route.meta[ $attrs[keyAttr] ];
+            $element.attr('content', content);
           }
-
-          $element.attr('content', content);
         };
 
         /**

diff --git a/tests/unit/meta.js b/tests/unit/meta.js
@@ -45,6 +45,8 @@ describe('sn.meta:meta directive', function() {
         }
       })
       expect(element.attr('content')).not.toEqual('some content');
+      expect(element.attr('content')).not.toEqual('');
+      expect(element.attr('content')).toEqual('Page description. No longer than 155 characters.');
     });
   });