Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: travis deploy #3

Merged
merged 6 commits into from Feb 6, 2015
Merged

Feature: travis deploy #3

merged 6 commits into from Feb 6, 2015

Conversation

jamesjwarren
Copy link
Member

This PR adds travis deployment. Releases are triggered on pushing a tag.

Issues to resolve:

  • version number is not taken from release tag, it is simply bumped so could get out of sync

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 37679d4 on feature/travis-deploy into 660d34c on develop.

"build",
"bump"
]);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have 2 release tasks in this gruntfile, i think this one would get overwritten

@edoparearyee
Copy link
Collaborator

@jamesjwarren if grunt bump only increments the version number, we need to find a solution that allows us to specify version number ideally from the git tag

@jamesjwarren
Copy link
Member Author

grunt bump accepts an absolute version passed to it so we just need to find a way to extract this info from the git tag.

@edoparearyee
Copy link
Collaborator

can you pass the tag in the form of a grunt option? something like:
grunt release -v 1.2.3

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 80a6645 on feature/travis-deploy into 660d34c on develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1edff06 on feature/travis-deploy into 660d34c on develop.

@edoparearyee
Copy link
Collaborator

This looks good to me, well done! 👍

edoparearyee added a commit that referenced this pull request Feb 6, 2015
@edoparearyee edoparearyee merged commit a86c714 into develop Feb 6, 2015
@jamesjwarren jamesjwarren deleted the feature/travis-deploy branch February 9, 2015 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants