Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/initial velocity directives #1

Closed
wants to merge 10 commits into from

Conversation

jamesjwarren
Copy link
Member

Initial PR with velocity directives.

Do we need all the angular-seed info in the README, I don't think all of it is relevant (esp the app structure)?

Still need to add tests.

@@ -0,0 +1,28 @@
"use strict";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's necessary to use namespace for filenames you can just call the files velocity.js and velocity-group.js

http://stackoverflow.com/questions/7273316/what-is-the-javascript-filename-naming-convention

@edoparearyee
Copy link
Collaborator

@jamesjwarren I think the angular seed stuff is useful for someone not familiar to node, grunt, bower etc... who wants to add stuff to this lib, if theres anything that isn't accurate like the folder structure then you should update it. The README should include instructions on how to use the library e.g. through bower and how to build the app, run tests etc..

@jamesjwarren
Copy link
Member Author

Updated and added unit tests, so if it passes should ok to merge.

@edoparearyee
Copy link
Collaborator

@jamesjwarren looks good, you should do the PR into the develop branch

@edoparearyee edoparearyee deleted the feature/initial-velocity-directives branch February 11, 2015 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants