Fix: disable skrollr on sm/xs viewport sizes #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| snSkrollr.init(); | ||
| if ($window.innerWidth > 1023) { | ||
| snSkrollr.init(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Yeah i think you should disable it for mobile, maybe link this logic to the ResizeService? But I don't know if skrollr has a function to disable and renable itself
There was a problem hiding this comment.
I think it has skrollr.destory() so linking with the ResizeService could work.
|
👍 |
jamesjwarren
added a commit
that referenced
this pull request
Feb 10, 2015
Fix: disable skrollr on sm/xs viewport sizes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skrollr causes some issues on mobile. It is recommended to use
id=skrollr-bodyon the scrollable element, skrollr then disabled native scrolling and uses css transforms. However as our menu and projects overlay areposition: fixedthis causes issues. Theposition: fixedelements can be set outside theskrollr-bodyhowever they are still not scrollable, as skrollr disables native scrolling on mobile (in favour of a css transforms method).As we aren't actually using skrollr on mobile/tablet at the moment anyway (atm it is used only for the soon logo in desktop view) I have disabled skrollr initialisation if the viewport is smaller than 1024.