Feature: add https to link filtering #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,7 +9,7 @@ angular.module("thisissoon.core").filter("linkDisplay", [ | |||
| "$filter", | |||
| function($filter) { | |||
| return function(input) { | |||
| return input.replace("http://", "").replace("www.", ""); | |||
| return input.replace("http://", "").replace("https://", "").replace("www.", ""); | |||
| }; | |||
There was a problem hiding this comment.
@jamesjwarren would it not be better to use regex for this? something like: /[a-zA-Z]+:\/\// would match any protocol and: /w{3}./would match www.
| @@ -9,7 +9,7 @@ angular.module("thisissoon.core").filter("linkDisplay", [ | |||
| "$filter", | |||
| function($filter) { | |||
| return function(input) { | |||
| return input.replace("http://", "").replace("www.", ""); | |||
| return input.replace(/.*?:\/\//g, "").replace(/w{3}./, "").replace(/\/.*/g, ""); | |||
| }; | |||
There was a problem hiding this comment.
@jamesjwarren have you tested this? this is a classic case for unit testing
There was a problem hiding this comment.
There are tests for this here: https://github.com/thisissoon/thisissoon-frontend/blob/feature/link-filter/tests/unit/thisissoon-core/filters/linkDisplay.js but I could probably add a few more cases. I'll do that now.
jamesjwarren
added a commit
that referenced
this pull request
Feb 11, 2015
Feature: add https to link filtering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.