TODOs + Corrections #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- h function seems to match MATLAB functionality. Also tried multiple examples and the results matched. colSums not needed - ' operator in MATLAB computes the complex conjugate transpose so Conj() calls are necessary for any matrix with complex number entries. - svds replacement matches MATLAB functionality exactly. Also tried multiple examples and the results matched. Corrections: - line 90: added min_step if statement to match MATLAB code in line 90 -line 153: to match MATLAB code in line 154
thisjustinh
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs:
Corrections:
-line 153: to match MATLAB code in line 154