Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail on io.js #163

Closed
bendrucker opened this issue Apr 30, 2015 · 1 comment
Closed

Tests fail on io.js #163

bendrucker opened this issue Apr 30, 2015 · 1 comment
Assignees

Comments

@bendrucker
Copy link
Collaborator

There are some reference errors around window not being defined. This is just a reminder for me to come back and look at it.

@bendrucker bendrucker self-assigned this Apr 30, 2015
@thlorenz
Copy link
Owner

Thanks Ben, I also noticed these but didn't have time to look into them.
From what I can tell they are related to jsdom.
I tried to upgrade jsdom but that made things worse. At that point I ran out of time.

Here's what I'd suggest:

  • upgrade to latest jsdom, fix the calls to it so tests pass on 0.10
  • hope that they also pass in 0.12 and io.js
  • if not we have a bigger problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants