Jason/remove bom

[jhnstn]

Browserify will remove Byte Order Marks when it bundles a package.
see browserify/browserify#313 for some discussion on this.

But shiming the same file preserves the BOM and moves it down from the first character in the file.
This makes it difficult to remove with build tools.

This PR removes BOMs from packages before they are shimmed. I didn't add any configuration flag since browserify itself doesn't seem to either.

[thlorenz]

Could you please clean that up? Leave my white-space as is please. Only apply the changes that are absolutely necessary to implement and test this feature.

Thanks.

[jhnstn]

I reverted the white space changes.
The test is https://github.com/jhnstn/browserify-shim/blob/jason/remove-bom/test/shim/shim-bom.js
and its fixture https://github.com/jhnstn/browserify-shim/blob/fa189acb631f6716d5fb1e1f1ab8695beded75ec/test/shim/fixtures/bom.js

Unfortunately it's difficult to see the BOM in the shim. I can add a test to make sure the fixture doesn't lose the one it has.

[thlorenz]

Ok, now I can actually see what you are doing, thanks.

I'm not sure that this belongs with browserify-shim though. Correct me if I'm wrong, but wouldn't this have to be added to EVERY transform that wraps the content?

Maybe it'd be better to make browserify remove it even it it's not at the beginning of the file (due to transfomations) or even better have browserify fix the files before passing them on to the transforms.

cc @substack

[jhnstn]

I agree that this should not be in browserify-shim. closing