Altered commentRx to avoid a RangeError under certain conditions in io.js (this time with better regexes).

[greim]

Incorporates some of the changes discussed here: #11 (comment)

[thlorenz]

Could you please rebase this on master and squash into one commit?
Thanks.

[thlorenz]

Any news on this? I believe with the latest patch we touched a regex but not the one you changed, so it should still be easy to rebase this.

[greim]

Okay. Rebased on master, fixed a conflict, had to type git rebase --skip, then squash merged all of that back to master. All to fix a regex. But now it's not on this branch anymore. Want me to make a new PR?

[thlorenz]

Yes you can just create a new PR. We can review there what you did and pull it in if all is well.

All to fix a regex

Don't belittle that, optimizing the regex makes a huge difference, so I thank you for taking the time and doing so.
If you think about it, this entire module is mainly a glorified wrapper around using that regex ;)

[greim]

Closing in favor of a simpler PR.

[dmitry]

@greim what was that?

[greim]

The essence of the fix had been changing .+ to ..* in a regex. My guess was it was triggering an arcane v8 bug which only happened in very specific circumstances. I eventually just re-ordered some adjacent-but-unrelated gulp tasks and the problem went away :)

[dmitry]

@greim thanks for the response! I've similarly fixed an issue: demerzel3/karma-sourcemap-loader#18

In my case it happened on every second pass to match the string, I believe it's somehow related to the V8 regex optimizations.