Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum size of isolate log file? #18

Closed
pbadenski opened this issue Nov 9, 2020 · 2 comments
Closed

Maximum size of isolate log file? #18

pbadenski opened this issue Nov 9, 2020 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@pbadenski
Copy link
Collaborator

Is there a maximum supported file size for isolate log file?

Getting this for an 800MB isolate-*-v8.log file:

node:buffer:592
    slice: (buf, start, end) => buf.utf8Slice(start, end),
                                    ^

Error: Cannot create a string longer than 0x1fffffe8 characters
    at Object.slice (node:buffer:592:37)
    at Buffer.toString (node:buffer:789:14)
    at Object.readFileSync (node:fs:421:41)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1110:18)
    at Module.load (node:internal/modules/cjs/loader:948:32)
    at Function.Module._load (node:internal/modules/cjs/loader:789:14)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:72:12)
    at node:internal/main/run_main_module:17:47 {
  code: 'ERR_STRING_TOO_LONG'
}
@thlorenz
Copy link
Owner

Ah, well in this case it's the actual runtime that limits that.
The only option to fix would be to not load the entire file, but parse it in a streaming manner.
That would require a ton of changes, but I'm open to PRs :)

@pbadenski
Copy link
Collaborator Author

pbadenski commented Jun 10, 2021

Fixed by #20; released in 0.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants