Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom marker style #108

Closed
kachkaev opened this issue Jun 10, 2016 · 6 comments
Closed

Custom marker style #108

kachkaev opened this issue Jun 10, 2016 · 6 comments

Comments

@kachkaev
Copy link

kachkaev commented Jun 10, 2016

I'm linting my *.md with remark-linter and one rule I'm checking the files against is that the markers should be * rather than - (markdown equally supports both of these options).

It would be nice if I could tell doctoc which of the two marker symbols to use in order to avoid linter errors.

@jez
Copy link
Collaborator

jez commented Jun 10, 2016

I agree! I've got a number of bug-related issues on my plate before I can consider feature requests, but if you really want you're welcome to open a PR (with tests :D).

@kachkaev
Copy link
Author

kachkaev commented Jun 10, 2016

Hi @jez! I'm afraid I won't be able to send a PR – not enough time. I just came across your project and tried it on a small app, but decided not to use it for now. I'm keeping an eye on doctoc and will be happy to npm install it again when there's a real need. What you've done looks very useful indeed!

@sheriferson
Copy link
Contributor

Hi @jez, I'd like to try and implement this feature (pass an argument/flag to doctoc to use * instead of -), but I'm a bit new to js. What's the best way to run the included tests on my local machine? (running OSX if it makes a difference but my guess is that it doesn't).

@jez
Copy link
Collaborator

jez commented Jun 11, 2016

On my phone right now but

npm test

should work if I recall correctly.
On Fri, Jun 10, 2016 at 6:36 PM Sherif Soliman notifications@github.com
wrote:

Hi @jez https://github.com/jez, I'd like to try and implement this
feature (pass an argument/flag to doctoc to use * instead of -), but I'm
a bit new to js. What's the best way to run the included tests on my local
machine? (running OSX if it makes a difference but my guess is that it
doesn't).


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#108 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AFSaVH_sMMTXgAcMDzD27IzffgiJVpkmks5qKhEWgaJpZM4Iy3Dj
.

@sheriferson
Copy link
Contributor

That worked, thanks. Simple enough!

On 10 Jun 2016, at 18:52, Jake Zimmerman wrote:

On my phone right now but

npm test

should work if I recall correctly.
On Fri, Jun 10, 2016 at 6:36 PM Sherif Soliman
notifications@github.com
wrote:

Hi @jez https://github.com/jez, I'd like to try and implement this
feature (pass an argument/flag to doctoc to use * instead of -), but
I'm
a bit new to js. What's the best way to run the included tests on my
local
machine? (running OSX if it makes a difference but my guess is that
it
doesn't).


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#108 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AFSaVH_sMMTXgAcMDzD27IzffgiJVpkmks5qKhEWgaJpZM4Iy3Dj
.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#108 (comment)

@jez
Copy link
Collaborator

jez commented Jun 13, 2016

The fix for this is on master, but has yet to be released in an npm version. Feel free to pull doctoc in using git in your package.json if you want the features from the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants