Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for skipping(Handle file skipping internally #143) #206

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Add unit test for skipping(Handle file skipping internally #143) #206

merged 1 commit into from
Jun 17, 2021

Conversation

wolfcon
Copy link
Contributor

@wolfcon wolfcon commented Jun 11, 2021 •
edited
Loading

@wolfcon wolfcon mentioned this pull request Jun 11, 2021
Merged
@wolfcon
Copy link
Contributor Author

wolfcon commented Jun 15, 2021

@AndrewSouthpaw PR this test?🧐
#143 has been already accepted.

@AndrewSouthpaw
Copy link
Collaborator

Oops thanks, missed this 😅

@AndrewSouthpaw AndrewSouthpaw merged commit dcbdb1c into thlorenz:master Jun 17, 2021
@AndrewSouthpaw
Copy link
Collaborator

Next time, I think it'd be better to roll them into the same PR.

@wolfcon
Copy link
Contributor Author

wolfcon commented Jun 17, 2021 •
edited
Loading

Next time, I think it'd be better to roll them into the same PR.

That would great. I just can't commit his PR. So... merge his commit and recreate this PR.

Maybe close old PR and accept this is a better option. (I retain his commit in this PR. not copycat.)

@AndrewSouthpaw
Copy link
Collaborator

Oh! Sorry I didn't notice you weren't the same person. My bad!

Seems like it's all squared away now.

@wolfcon
Copy link
Contributor Author

wolfcon commented Jun 18, 2021

nm🤪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewSouthpaw AndrewSouthpaw AndrewSouthpaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wolfcon @AndrewSouthpaw