Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please upgrade source-map to 0.7.2 to get speed improvements #21

Open
andreicristianpetcu opened this issue Mar 4, 2018 · 1 comment

Comments

@andreicristianpetcu
Copy link

The latest source-map which is v0.7.2 got support for WebAssembly and it is 10 times faster than the old one. More info here:

https://github.com/mozilla/source-map/blob/master/CHANGELOG.md#072
http://fitzgeraldnick.com/2018/02/26/speed-without-wizardry.html
https://hacks.mozilla.org/2018/01/oxidizing-source-maps-with-rust-and-webassembly/
firefox-devtools/debugger#5598

Please update so you would get 10 times speed improvements for your library in Firefox, 9 times in Safari and 5 times in Chrome.

@thlorenz
Copy link
Owner

thlorenz commented Jun 8, 2018

I agree we should do that.
However currently we have failing tests which prevent any upgrade see here.

Maybe you want to help get that in order first and then you can provide a PR with the update?

Thanks.

BTW I am aware of those change that got applied to the source-map package, however this is a super interesting read explaining that WebAssembly wasn't really needed after all ;)

@legobeat legobeat mentioned this issue Feb 25, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants