Use concat-stream for buffering stream contents #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirxpilot
added a commit
to pirxpilot/exorcist
that referenced
this pull request
Jun 26, 2019
since every chunk was converted to string separately when chunk/buffer boundary falls into multibyte character we end up with invalid sources the fix relies on concatenating all the chunks into a single Buffer before decoding the resulting buffer to String see: thlorenz/mold-source-map#9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are running into an issue where occasionally a surrogate pair in our bundle is being split and the string concatenation method used here is causing the output to be invalid. This switches the buffering to be done with
concat-streamso that it is operating on the raw buffers and only converted to a string once it is complete.