buffer as a string

[crdx]

Just curious, what's the reason behind splitting up the string "buffer"?

function toUint8Array (s) {
  if (typeof atob === 'function') return new Uint8Array(atob(s).split('').map(charCodeAt))
  return new (require('buf' + 'fer').Buffer)(s, 'base64')
}

https://github.com/thlorenz/wasm2js/blob/master/wasm2js.js#L70

[crdx]

Might be more a question for @mafintosh as I see now this code originally came from wat2js.

[mafintosh]

It’s to avoid browserifying buffer since that code is only used in Node.js

…

On Sat, 1 Dec 2018 at 03.49, crdx ***@***.***> wrote: Might be more a question for @mafintosh <https://github.com/mafintosh> as I see now this code originally came from wat2js — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAW_Ve_sQBa92U-Sv6QS8eRLCfQ9tOOfks5u0mzIgaJpZM4Y825d> .

[crdx]

Ah, I see. Thanks!