Fixing the uncaught error when a Country doesnt exist #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -79,7 +79,7 @@ function generate_name ($database, $country = ANY, $language = ANY, $gender = AN | |||
| } | |||
| } | |||
|
|
|||
| if (!$found) throw new Exception('No matching pool found'); | |||
| if (!$found) throw new Exception('No matching country or language found'); | |||
There was a problem hiding this comment.
I'd prefer to keep calling this pool as it's not just country or language, it's any top level entry in the database, usually selected by just a country or a country and language combination, but never just a language. The code also commonly uses the word pool.
|
If you can change that I'll merge it. |
|
Sure thing :) 2015-01-16 11:23 GMT-05:00 Claudio Albertin notifications@github.com:
|
|
Just updated it |
thm
pushed a commit
that referenced
this pull request
Feb 17, 2015
Fixing the uncaught error when a Country doesnt exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.