Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HookSystem usable in modules #143

Closed
thmarx opened this issue Jan 4, 2024 · 2 comments
Closed

Make HookSystem usable in modules #143

thmarx opened this issue Jan 4, 2024 · 2 comments
Milestone

Comments

@thmarx
Copy link
Owner

thmarx commented Jan 4, 2024

What if a module is using the HookSystem, currently I see a problem because it is request scope.

Maybe we need global HookSystem for these cases.

@thmarx thmarx added this to the 4.0.0 milestone Jan 4, 2024
@thmarx
Copy link
Owner Author

thmarx commented Jan 6, 2024

Use HookSystemRegisterExtentionPoint to register callback for hook.

To call a hook, you can use the ThreadLocalRequestContext.get(HookSystemFeature.class).
But that will only work on a request based execution

@thmarx thmarx removed this from the 4.0.0 milestone Jan 6, 2024
@thmarx thmarx added this to the 4.4.0 milestone Jan 17, 2024
@thmarx
Copy link
Owner Author

thmarx commented Jan 17, 2024

This is no easy possible by using the CMSRequestContext in modules.

thmarx pushed a commit that referenced this issue Jan 17, 2024
@thmarx thmarx closed this as completed Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant