Remove redisClient in favour of UniversalClient #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove our interface `redisClient` and swap it for goredis' `redis.UniversalClient` interface. This fixes the inability to provide custom brokers with goredis v7.
Corrects the custom-broker example. You can no longer pass a RedisBroker struct due to an unexported Mutex variable being unset.
|
thank you for your PR, published under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove our interface
redisClientand swap it for goredis'redis.UniversalClientinterface. This fixes the inability to provide custom brokers with goredis v7.Couldn't see any reason as to why redisClient was being used. This allows the passing of a redis client as a custom broker, and updates the custom broker example.
If possible, would we be able to get a new release too? That way the redis v7 and these changes are easy to use :)