This repository has been archived by the owner on Aug 4, 2020. It is now read-only.
Split monolitic files #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umentation. If you are using Cassandra, you are probably not on shared hosting, so you should be able to upgrade. What is more important PHP 5.2 is not even officially supported anymore (aside from security patches).
…ion in ConnectionPool to improve performance)
|
Thanks for the great pull request; I should have all of the changes into the master branch shortly. I haven't been working with PHP for very long, so I'm not all that familiar with typical practices. Any other suggestions/pull requests along these lines are extremely welcome. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation with all the classes (without phpcassa prefix nor namespace) in a 3 long files is really not too great to work with. Is there a good reason why this is not following a more classic model like this (in compliance with PSR-0 standard):