Github Action should use the same lint command as local #71
Conversation
alok87
force-pushed
the
fix-69-use-make-lint
branch
from
da27ce5
to
a913f31
Compare
Docker is already installed on ubuntu https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2004-Readme.md#tools
alok87
force-pushed
the
fix-69-use-make-lint
branch
from
a913f31
to
44521ae
Compare
| -E unused | ||
| -E varcheck | ||
| - name: Lint code | ||
| run: make lint |
| steps: | ||
| - name: Install Go |
There was a problem hiding this comment.
super minor, but your editor indents list items and mine doesn't. Can you make it the same whitespace as test.yaml, please?
|
There's not much point in doing the matrix of versions once we are using a docker image, it will always use the same Go version, right? |
thockin
force-pushed
the
master
branch
7 times, most recently
from
02a976e
to
72d5128
Compare
|
I changed the test and crossbuild actions to use make - look at those? |
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| go-versions: [ 1.16.x, 1.17.x, 1.18.x, 1.19.x ] |
There was a problem hiding this comment.
For lint, you can get rid of this axis in the matrix, and remove the "install" step
| strategy: | ||
| matrix: | ||
| go-versions: [ 1.16.x, 1.17.x, 1.18.x, 1.19.x ] | ||
| platform: [ ubuntu-latest, windows-latest ] |
There was a problem hiding this comment.
let's remove Windows - it doesn't practically work
|
To convince myself, I ended up just making the change myself, sorry. |
|
Yes, docker is installed in the ubuntu latest ones and we can use it in GH https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2004-Readme.md#tools This also needs to be fixed #73 |
Fixes #69
The nice thing of having a
make lintis it runs tasks in docker container that works in any environment. We do not need to maintain multiple lint settings in multiple files and we can reuse the samemake lint.