Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support emojis on desc #1

Merged
merged 1 commit into from May 9, 2022
Merged

Support emojis on desc #1

merged 1 commit into from May 9, 2022

Conversation

rata
Copy link
Contributor

@rata rata commented May 9, 2022

Hi Tim, I liked these scripts and I was using them as base for a demo of my own. I ended up adding the "-e" flag to the echo on desc() so I can print emojis.

I don't know if you want (very simple) PRs for this or not. But I thought it is better to contribute back, it is completely fine if you don't want to take PRs for this :)

The other thing I ended up doing for my demos is adding a "desc_type", that just adds the comment typing them slowly instead of instantly as "desc" does. You can see my branch here, just in case.

Below is the commit msg of the commit in this PR.


With this commit, you can print an emoji using its unicode, like:

# tada emoji
desc "\U1F389"

With this commit, you can print an emoji using its unicode, like:

	# tada emoji
	desc "\U1F389"
@rata
Copy link
Contributor Author

rata commented May 9, 2022

Oh, no one assigned, so tagging you just in case @thockin

@thockin thockin merged commit 93b30e6 into thockin:master May 9, 2022
@thockin
Copy link
Owner

thockin commented May 9, 2022

thanks!

Github has no way to auto-assign, and I miss things that are not assigned, sometimes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants