Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protection against overwriting the key if it already exists in the DB #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RostyslavPin
Copy link

When you try to add the same key in db its overwriting.
Adding a check whether such a key already exists in the database.

Copy link
Owner

@thodnev thodnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!
But reading file to check whether it exists is overkill. This is better done with access(), stat(), or at worst with fopen(). And that logic should be placed in item_write() or xopen()

@thodnev thodnev mentioned this pull request Jul 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants