better handling of invalid project files

thoemmi · Jan 4, 2015 · 65bbd3a · 65bbd3a
1 parent 9f1c99b
commit 65bbd3a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/Solutionizer.sln.DotSettings b/Solutionizer.sln.DotSettings
@@ -98,6 +98,7 @@
 	<s:String x:Key="/Default/CodeStyle/Naming/XamlNaming/UserRules/=XAML_005FRESOURCE/@EntryIndexedValue">&lt;Policy Inspect="True" Prefix="" Suffix="" Style="AaBb" /&gt;</s:String>
 	<s:String x:Key="/Default/CodeEditing/Localization/Localizable/@EntryValue">No</s:String>
 	<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ESettingsUpgrade_002EMigrateBlankLinesAroundFieldToBlankLinesAroundProperty/@EntryIndexedValue">True</s:Boolean>
+	<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ESettingsUpgrade_002EMigrateThisQualifierSettings/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002EJavaScript_002ECodeStyle_002ESettingsUpgrade_002EJsCodeFormatterSettingsUpgrader/@EntryIndexedValue">True</s:Boolean>
 
 

diff --git a/Solutionizer/Models/Project.cs b/Solutionizer/Models/Project.cs
@@ -13,7 +13,7 @@ public class Project {
         private string _assemblyName;
         private Guid _guid;
         private bool _isSccBound;
-        private List<string> _projectReferences;
+        private List<string> _projectReferences = new List<string>();
         private readonly List<string> _brokenProjectReferences = new List<string>();
         private readonly List<string> _errors = new List<string>();
         private Task<IList<string>> _taskLoadConfigurations;
@@ -47,7 +47,13 @@ public class Project {
                 throw new ArgumentException("Not a valid VS2005 C# project file: \"" + _filepath + "\"");
             }
 
-            var assemblyName = xmlDocument.GetElementsByTagName("AssemblyName")[0].FirstChild.Value;
+            var assemblyNameElements = xmlDocument.GetElementsByTagName("AssemblyName");
+            if (assemblyNameElements.Count == 0) {
+                _errors.Add("Not a valid project file.");
+                return;
+            }
+
+            var assemblyName = assemblyNameElements[0].FirstChild.Value;
             var guid = Guid.Parse(xmlDocument.GetElementsByTagName("ProjectGuid")[0].FirstChild.Value);
             var directoryName = Path.GetDirectoryName(_filepath);