Modified skybox renderer to be more robust

made views a processbehaviour so they can be more usefully extended Signed-off-by: Martin Evans <martindevans@gmail.com>
TomGillen · Oct 7, 2013 · 84b9bef · 84b9bef
1 parent 86bf329
commit 84b9bef
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 14 deletions.
diff --git a/Myre/Myre.Graphics/Deferred/LightManagers/DeferredSkyboxManager.cs b/Myre/Myre.Graphics/Deferred/LightManagers/DeferredSkyboxManager.cs
@@ -12,6 +12,13 @@ public class DeferredSkyboxManager
         readonly Effect _skyboxEffect;
         readonly Quad _quad;
 
+        private readonly DepthStencilState _depthState = new DepthStencilState
+        {
+            DepthBufferEnable = true,
+            DepthBufferWriteEnable = false,
+            DepthBufferFunction = CompareFunction.LessEqual
+        };
+
         public DeferredSkyboxManager(GraphicsDevice device)
         {
             _skyboxEffect = Content.Load<Effect>("Skybox");
@@ -29,25 +36,18 @@ public void Draw(Renderer renderer)
             var device = renderer.Device;
 
             var previousDepthState = device.DepthStencilState;
-            //device.DepthStencilState = DepthStencilState.DepthRead;
-            device.DepthStencilState = new DepthStencilState()
-            {
-                DepthBufferEnable = true,
-                DepthBufferWriteEnable = false,
-                DepthBufferFunction = CompareFunction.LessEqual
-            };
+            device.DepthStencilState = _depthState;
 
             var previousRasterState = device.RasterizerState;
-            device.RasterizerState = RasterizerState.CullCounterClockwise;
-
-            //device.SetVertexBuffer(vertices);
-            //device.Indices = indices;
+            device.RasterizerState = RasterizerState.CullNone;
 
             var part = _model.Meshes[0].MeshParts[0];
             device.SetVertexBuffer(part.VertexBuffer);
             device.Indices = part.IndexBuffer;
 
-            _skyboxEffect.Parameters["View"].SetValue(renderer.Data.GetValue<Matrix>("view"));
+            var view = renderer.Data.GetValue<Matrix>("view");
+            view.Translation = Vector3.Zero;
+            _skyboxEffect.Parameters["View"].SetValue(view);
             _skyboxEffect.Parameters["Projection"].SetValue(renderer.Data.GetValue<Matrix>("projection"));
 
             for (int i = 0; i < Behaviours.Count; i++)

diff --git a/Myre/Myre.Graphics/View.cs b/Myre/Myre.Graphics/View.cs
@@ -8,7 +8,7 @@ namespace Myre.Graphics
 {
     [DefaultManager(typeof(Manager))]
     public class View
-        : Behaviour
+        : ProcessBehaviour
     {
         private Property<Camera> _camera;
         private Property<Viewport> _viewport;
@@ -41,9 +41,12 @@ public void SetMetadata(RendererMetadata metadata)
             _camera.Value.SetMetadata(metadata);
         }
 
+        protected override void Update(float elapsedTime)
+        {
+        }
 
         public class Manager
-            : BehaviourManager<View>
+            : Manager<View>
         {
             public IEnumerable<View> Views
             {