lib/data.c: avoid memleak if realloc fails

thom311 · Jun 8, 2017 · 8d807b2 · 8d807b2
1 parent 77a4c15
commit 8d807b2
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/lib/data.c b/lib/data.c
@@ -111,15 +111,16 @@ struct nl_data *nl_data_clone(const struct nl_data *src)
 int nl_data_append(struct nl_data *data, const void *buf, size_t size)
 {
 	if (size > 0) {
-		data->d_data = realloc(data->d_data, data->d_size + size);
-		if (!data->d_data)
+		void *d_data = realloc(data->d_data, data->d_size + size);
+		if (!d_data)
 			return -NLE_NOMEM;
 
 		if (buf)
-			memcpy(data->d_data + data->d_size, buf, size);
+			memcpy(d_data + data->d_size, buf, size);
 		else
-			memset(data->d_data + data->d_size, 0, size);
+			memset(d_data + data->d_size, 0, size);
 
+		data->d_data = d_data;
 		data->d_size += size;
 	}