Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

route: Add extra support for bridge vlan and dynamic bridge table. #372

Closed
wants to merge 3 commits into from

Conversation

Cordell-O
Copy link
Contributor

No description provided.

@thom311
Copy link
Owner

thom311 commented Jan 8, 2024

Thank you for the patch!

There are some issues in CI (compiler warnings). Are you able to address those?

you can reformat the files by running ./tools/clang-format.sh. That requires that you have a suitable clang-format version installed. Alternatively, you can use ./tools/clang-format-container.sh (which requires a working podman and will build a Fedora container). If both is too cumbersome, you can also ignore the formatting issue, and I will reformat before merging.

libnl-route-3.sym Show resolved Hide resolved
lib/route/link/bridge_info.c Show resolved Hide resolved
lib/route/link/bridge.c Outdated Show resolved Hide resolved
lib/route/link/bridge.c Outdated Show resolved Hide resolved
lib/route/link/bridge.c Show resolved Hide resolved
include/netlink/route/link/bridge.h Outdated Show resolved Hide resolved
lib/route/link/bridge.c Outdated Show resolved Hide resolved
@Cordell-O
Copy link
Contributor Author

Sorry for the slow response time, ive address all feedback, unsure about the test suite any feedback is appreciated.

lib/route/link/bridge.c Outdated Show resolved Hide resolved
lib/route/link/bridge.c Outdated Show resolved Hide resolved
lib/route/link/bridge.c Outdated Show resolved Hide resolved
lib/route/link/bridge.c Outdated Show resolved Hide resolved
lib/route/link/bridge.c Show resolved Hide resolved
include/nl-priv-static-route/nl-priv-static-route.h Outdated Show resolved Hide resolved
tests/check-direct.c Outdated Show resolved Hide resolved
tests/check-direct.c Show resolved Hide resolved
@thom311
Copy link
Owner

thom311 commented Feb 29, 2024

lgtm. Merged to main.

Thank you for your contribution!!

@thom311 thom311 closed this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants