Skip to content
This repository has been archived by the owner on Apr 21, 2024. It is now read-only.

React Navigation Modal Fix #44

Merged
merged 2 commits into from Jul 28, 2021
Merged

Conversation

thomas-coldwell
Copy link
Owner

@thomas-coldwell thomas-coldwell merged commit 084bcf9 into develop Jul 28, 2021
@DeWulfJerome
Copy link

Just opened an issue on this, my bad!
Any idea when you'll have the time to publish this?

Great work btw

@thomas-coldwell
Copy link
Owner Author

Thanks dude! Sorry I haven't had a chance to update the docs (will do shortly). If you use the component and add the the prop asView you can render it in a Stack Modal.

I've just discovered a bit of a new work around today which might be way better using portals:
react-navigation/react-navigation#9757 (comment)

Will try update the library shortly to include this behaviour as it makes it less specific to React Navigation 😀

@thomas-coldwell
Copy link
Owner Author

I've updated the docs now to show this! Feel feel to give it a try and if it still gives you any trouble do let me know :) #41 (comment)

@DeWulfJerome
Copy link

Thanks man! 👏 I'm on holiday now but will give it a try in 2 weeks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants