forked from rspec/rspec-core
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
No longer make define_method public, use send instead.
MemoizedHelpers::ClassMethods module was making define_method public for ease of use within the module. No longer do this and use send instead. This fixes rspec#873.
- Loading branch information
Thomas Holmes
committed
Apr 18, 2013
1 parent
5200ad6
commit 5280e95
Showing
1 changed file
with
2 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5280e95
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh, I just worked on this myself to, but I took the alternative approach and fixed the leak.
5280e95
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I tried to get that sorted out for a bit, but I didn't have much luck. I think I don't completely understand the cause of the problem.