Address clippy warnings in pokemon-service (smithy-lang#2399)

Co-authored-by: Yuki Saito <awsaito@amazon.com>
thomas-k-cameron · Feb 21, 2023 · ec1a551 · ec1a551
1 parent a40dbfc
commit ec1a551
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/rust-runtime/aws-smithy-http-server/examples/pokemon-service/src/lib.rs b/rust-runtime/aws-smithy-http-server/examples/pokemon-service/src/lib.rs
@@ -226,8 +226,8 @@ pub async fn capture_pokemon(
                     Some(event) => {
                         let capturing_event = event.as_event();
                         if let Ok(attempt) = capturing_event {
-                            let payload = attempt.payload.clone().unwrap_or(CapturingPayload::builder().build());
-                            let pokeball = payload.pokeball.as_ref().map(|ball| ball.as_str()).unwrap_or("");
+                            let payload = attempt.payload.clone().unwrap_or_else(|| CapturingPayload::builder().build());
+                            let pokeball = payload.pokeball.as_deref().unwrap_or("");
                             if ! matches!(pokeball, "Master Ball" | "Great Ball" | "Fast Ball") {
                                 yield Err(
                                     crate::error::CapturePokemonEventsError::InvalidPokeballError(
@@ -250,8 +250,7 @@ pub async fn capture_pokemon(
                                     let shiny = rand::thread_rng().gen_range(0..4096) == 0;
                                     let pokemon = payload
                                         .name
-                                        .as_ref()
-                                        .map(|name| name.as_str())
+                                        .as_deref()
                                         .unwrap_or("")
                                         .to_string();
                                     let pokedex: Vec<u8> = (0..255).collect();