Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Sentinelles PionNeutre is implemented incorrectly #352

Open
ildjarnisdead opened this issue May 7, 2023 · 1 comment
Open

BUG: Sentinelles PionNeutre is implemented incorrectly #352

ildjarnisdead opened this issue May 7, 2023 · 1 comment
Assignees
@thomas-maeder
Labels
bug

Comments

@ildjarnisdead
Copy link

ildjarnisdead commented May 7, 2023 •
edited

In Sentinelles PionNeutre, -any- piece leaves a neutral pawn. not just neutral pieces. Currently, only neutral pieces leave neutral pawns and white/black pieces leave white/black pawns.

Furthermore, there should be a MaximumNeutral option, and MaximumTotal should include the neutral pawns.
@thomas-maeder
Copy link
Owner

-any- piece leaves a neutral pawn

Not according to https://juliasfairies.com/fairy-terms/fairy-classification-project/fairy-classification-tabular/

@thomas-maeder thomas-maeder self-assigned this Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomas-maeder thomas-maeder

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomas-maeder @ildjarnisdead