Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/movement through history #76

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Feature/movement through history #76

wants to merge 2 commits into from

Conversation

nicholasmello
Copy link
Contributor

Movement Through History

Description

Adds the ability to look at previous moves using "P" and "N", if you try to make a move it will bring you back to the actual current position to continue playing.

Fixes #65

How Has This Been Tested?

Tested by playing moves to get to common scenarios where things can go wrong such as en passant and castling. Tests have been updated as well.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@nicholasmello nicholasmello force-pushed the feature/movement-through-history branch 2 times, most recently from 0304aea to 642e417 Compare June 30, 2024 07:18
@nicholasmello
Add movement through history
b6c1df3 
Adds the ability to move through history to view the moves that have
been played. This is NOT equivalent to an analysis board where you can
undo moves or look at other lines.

Signed-off-by: Nick Mello <nick@nmello.dev>
@nicholasmello
Add tests to history movement features
c87fdfe 
Signed-off-by: Nicholas Mello <nick@nmello.dev>
@nicholasmello nicholasmello force-pushed the feature/movement-through-history branch from 642e417 to c87fdfe Compare June 30, 2024 07:21
@nicholasmello nicholasmello mentioned this pull request Jul 5, 2024
Open
thomas-mauran
thomas-mauran approved these changes Jul 6, 2024
View reviewed changes
Copy link
Owner

@thomas-mauran thomas-mauran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks nice, didn't see any issues with the code, some parts could be rewritten for more readability as you mentionned in a TODO.

@thomas-mauran
Copy link
Owner

If you can rebase to fix the merge conflicts @nicholasmello then I will merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-mauran thomas-mauran thomas-mauran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Movement through history
2 participants
@nicholasmello @thomas-mauran