1st attempt to reveal magic parts #54
Conversation
listeners.js
Outdated
| } | ||
| }) | ||
|
|
||
| api.addListener(['post', 'put'], function updatePassword(req, collection, data) { | ||
| if (collection == 'users' && data.password && data.password.length != 60 && data.password[0] != "$") { | ||
| debug('setting new password') |
There was a problem hiding this comment.
Maybe mention hashing in this comment, since it's pretty important that the plaintext password field is replaced with a hashed version.
|
Looks like a good change. Each of these listeners should already get logged by name e.g. I see the output below when enabling debugging.
But I guess the names aren't very clear. I'm fine with your proposed adding of debug statements or we could make the function names longer so it's more clear what's going on, or maybe both :) |
many npm packages use the debug-module during development. This allows you to see more output in the console:
And you'll see the debug()-statements (instead of only the console.log statements)
The good thing is that addListener()-automatically uses this mechanism, which allows us to see which listeners are triggered.
I think there are more parts in the code which might need some debug calls