Keycloak: Simplify userSessions counting in metrics collection

thomasdarimont · May 17, 2023 · 0531e5c · 0531e5c
1 parent 1289228
commit 0531e5c
Showing 1 changed file with 2 additions and 12 deletions.
diff --git a/...ions/src/main/java/com/github/thomasdarimont/keycloak/custom/metrics/KeycloakMetrics.java b/...ions/src/main/java/com/github/thomasdarimont/keycloak/custom/metrics/KeycloakMetrics.java
@@ -132,18 +132,8 @@ public void updateRealmMetrics(KeycloakSession session, RealmMetricUpdater metri
 
     private RealmSessionStats collectRealmSessionStats(KeycloakSession session, RealmModel realm) {
 
-        Map<String, Long> userSessionsCounts = session.sessions().getActiveClientSessionStats(realm, false);
-        Map<String, Long> offlineUserSessionCounts = session.sessions().getActiveClientSessionStats(realm, false);
-
-        long userSessionsCount = 0L;
-        for (var entry : userSessionsCounts.entrySet()) {
-            userSessionsCount += entry.getValue();
-        }
-
-        long offlineSessionsCount = 0L;
-        for (var entry : offlineUserSessionCounts.entrySet()) {
-            offlineSessionsCount += entry.getValue();
-        }
+        var userSessionsCount = session.sessions().getActiveClientSessionStats(realm, false).values().stream().reduce(0L, Long::sum);
+        var offlineSessionsCount = session.sessions().getActiveClientSessionStats(realm, false).values().stream().reduce(0L, Long::sum);
 
         return new RealmSessionStats(userSessionsCount, offlineSessionsCount);
     }