-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add subtract converters #16
Feature/add subtract converters #16
Conversation
Merge develop with master
Merge develop to master
Ah ok, I thought the 'IsInverted' was already part of StringIsNullOrEmptyConverter.... cool thanks. I just had a quick look: It looks good. I'll check it out and merge it asap. |
Any progress on this one? I'd have ideas for more converters, but I'd need you to merge PR's and publish nuget packages. Otherwise I contribute but still have to maintain my local copy of the converter... |
Ups... yes 💯 sorry for the delay. I'm recently a bit under fire (like everyone I guess). I'm coming back to this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I refactored some tests to use xUnit Theory
I'm not 100% sure if these two converters (AddConverter, SubtractConverter) are such a great value. Don't get me wrong. I think such logic does a better job in a view model. Don't you think so too? What is your use case for these converters? |
I see your concerns. Thank you for merging the PR though. I use the converter in a MVVM app that draws little rectangles on a canvas. Canvas.Left/Top are bound to model.X/Y which define the center of a rectangle. As the size of the rectangle is a matter of the view, I decided to use a converter. It's an exotic use case - I admit. |
Please check if that meets your requirements - I tried to adapt to your approaches and base classes.
I can only compile full netframework stuff, not xamarin and uwp parts...
#15