Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main thing: Please ignore this if it is not to your taste.
I am reading your delightful book and running all the examples. I fiddled in the following ways on the Chapters 3 and 4 examples (so far), because I think it makes it clearer to readers how they work and what they do:
plot()
, which breaks in current Firedrake, in ch3 codes, to usetripcolor()
orquiver()
as appropriatePETSc.Sys.Print()
{2|3}d_product_elements.py
t
in days insw_linear_w2.py
andsw_nonlinear_w5.py
.gitignores
andmakefile
s, the latter just for amake clean
target to clean up results and figuresI'll do the same fiddles in
ch5_examples/
pretty soon, so no rush to merge.Only the first item is a bug fix. If you just want that as a pull request, let me know.