Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify example HTML & CSS #10

Merged
merged 6 commits into from Jul 29, 2018
Merged

Simplify example HTML & CSS #10

merged 6 commits into from Jul 29, 2018

Conversation

thomashoneyman
Copy link
Owner

What does this pull request do?

This PR makes the example forms look significantly nicer while also reducing the amount of HTML required to do so. The goal is to put the focus on the component and data types and not on the rendering while still showcasing forms that you'd actually want in your application.

Other Notes:

This also fixes a bug with the real-world example where validation would still run even if you disabled the form because the validation was not also removed.

@thomashoneyman thomashoneyman self-assigned this Jul 29, 2018
@thomashoneyman thomashoneyman merged commit 802cf47 into master Jul 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant