Use codec-argonaut instead of argonaut-codecs #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates Real World Halogen to use
codec-argonaut(https://github.com/garyb/purescript-codec-argonaut) instead of the typeclass-basedargonaut-codecs. Gary has written about the issues with typeclass-based codecs and, despite their convenience, at both CitizenNet and Awake Security we've ended up moving away from the type classes.Since the profunctor-based codecs are the better choice for most applications I've switched Real World Halogen to use them. I haven't had as much time to dedicate to this as I would like so I've missed some easy opportunities to make the code a little nicer. Still, I thought it was important to switch as soon as possible to serve as an example.